[GitHub] [incubator-mxnet] HahTK commented on a change in pull request #16131: Fix for duplicate subgraph inputs/outputs

[GitBox <gi...@apache.org>]

HahTK commented on a change in pull request #16131:
URL: https://github.com/apache/incubator-mxnet/pull/16131#discussion_r483745973



##########
File path: src/operator/subgraph/build_subgraph.cc
##########
@@ -537,10 +537,11 @@ void FindOutputEntries(nnvm::Graph* g,
  */
 void CutGraphInputs(const std::vector<nnvm::NodeEntry*> &input_entries,
                     std::vector<nnvm::NodeEntry> *orig_entries,
+                    std::vector<nnvm::NodeEntry> *unique_inputs,

Review comment:
       There is an alternative implementation that does not need t track the actual unique inputs separately.
   A counter would allow us to correctly modify orig_entries into unique_entries.
   This keeps the function signature unchanged and minimizes changes elsewhere.
   
   It is already working in a private build. I add it here for consideration if desired
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org