You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by gn...@apache.org on 2020/02/18 19:13:37 UTC

[incubator-nuttx-apps] branch master updated: Remove CONFIG_DEV_LOWCONSOLE from source code

This is an automated email from the ASF dual-hosted git repository.

gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git


The following commit(s) were added to refs/heads/master by this push:
     new eb8678c  Remove CONFIG_DEV_LOWCONSOLE from source code
eb8678c is described below

commit eb8678cfebc788b6dbaa412d75551581a6201043
Author: Xiang Xiao <xi...@xiaomi.com>
AuthorDate: Tue Feb 18 20:59:52 2020 +0800

    Remove CONFIG_DEV_LOWCONSOLE from source code
    
    Follow the nuttx side change
---
 examples/poll/poll_listener.c | 16 ++++++++--------
 nshlib/README.txt             | 10 ----------
 2 files changed, 8 insertions(+), 18 deletions(-)

diff --git a/examples/poll/poll_listener.c b/examples/poll/poll_listener.c
index f31f297..302a92f 100644
--- a/examples/poll/poll_listener.c
+++ b/examples/poll/poll_listener.c
@@ -59,15 +59,15 @@
  * Pre-processor Definitions
  ****************************************************************************/
 
-#if defined(CONFIG_DEV_CONSOLE) && !defined(CONFIG_DEV_LOWCONSOLE)
-#   define HAVE_CONSOLE
-#   define NPOLLFDS 2
-#   define CONSNDX  0
-#   define FIFONDX  1
+#ifdef CONFIG_DEV_CONSOLE
+#  define HAVE_CONSOLE
+#  define NPOLLFDS 2
+#  define CONSNDX  0
+#  define FIFONDX  1
 #else
-#   undef  HAVE_CONSOLE
-#   define NPOLLFDS 1
-#   define FIFONDX  0
+#  undef  HAVE_CONSOLE
+#  define NPOLLFDS 1
+#  define FIFONDX  0
 #endif
 
 /****************************************************************************
diff --git a/nshlib/README.txt b/nshlib/README.txt
index 716346d..25d8875 100644
--- a/nshlib/README.txt
+++ b/nshlib/README.txt
@@ -1946,16 +1946,6 @@ Common Problems
 ^^^^^^^^^^^^^^^
 
   Problem:
-    Using NSH over serial, the "nsh>" prompt repeats over and over again
-    with no serial input.
-  Usual Cause:
-    NSH over serial needs to use the interrupt driven serial driver
-    (drivers/serial/serial.c) not the polled serial driver (drivers/serial/lowconsole.c).
-    Make sure that the polled console is disabled in the OS configuration
-    file, .config.  That file should have CONFIG_DEV_LOWCONSOLE=n for
-    NSH over serial.
-
-  Problem:
     The function 'readline' is undefined.
   Usual Cause:
     The following is missing from your defconfig file: