You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2019/10/27 11:38:24 UTC

[GitHub] [commons-compress] bodewig commented on issue #84: COMPRESS-477 Add support for extracting splitted zip files

bodewig commented on issue #84: COMPRESS-477 Add support for extracting splitted zip files
URL: https://github.com/apache/commons-compress/pull/84#issuecomment-546686157
 
 
   Many thanks @PeterAlfreadLee I'll need some time to fully review the PR.
   
   As for `ZipArchiveInputStream` I completely agree with you that (virtually) concatenating the files into single stream should be almost enough. We'd need a way to deal with section 8.5.3 of https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT as `zipArchiveInputStream` currently rejects files with the split marker https://github.com/apache/commons-compress/blob/205876d6f9eb60ac31f3ec848b23d025f32995ab/src/main/java/org/apache/commons/compress/archivers/zip/ZipArchiveInputStream.java#L370 . We could either allow people using `ZipArchiveInputStream` to signal it should skip the marker or provide a "collecting stream" that skipped the first four bytes if necessary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services