[GitHub] cwanda commented on issue #198: MYNEWT-762 Doc Update for 1.1 newtmgr conn add format

[gi...@git.apache.org]

cwanda commented on issue #198: MYNEWT-762 Doc Update for 1.1 newtmgr conn add format
URL: https://github.com/apache/incubator-mynewt-site/pull/198#issuecomment-308292159
 
 
   Hi Chris, Thanks for reviewing the updates. Regarding your comment. The `name` field here is not the `peer_name` that is specified in the connstring. My understanding is that the `peer_name`  in the connstring is what the ble device advertises and what newtmgr uses for discovery.  I may have missed something in the code, but from what I can see, the `name` variable specifies the name of the connection profile.  For example, if I entered this command `newtmgr conn add myble name=bleconnection type=ble connstring="peer_name=nrf52_ble"`,   then when I do a `newtmgr conn show`, I would get this as the output:
    `bleconnection: type=ble, connstring='peer_name=nrf52_ble'`. 
   
   Having said that, I am actually not sure why the  `newtmgr conn add` command allows both the required <conn_profile> argument and the optional `name` variable (The ConnProfile name field takes the value of <conn_profile> if the optional `name` variable is not set.)  It is actually a bit confusing because if the user provides the optional `name` variable, then  the value of `name` overrides the <conn_profile> value and the user has to use the value of `name` to refer to the connection profile. The system does not know about the <conn_profile> connection profile.  That is, for the example above, newtmgr knows about the `bleconnection` profile but not the `myble` profile.   Not sure of the reason  when a user might  want to use the optional `name` parameter to override the value of <conn_profile>.  It seems they can just specified the <conn_profile> value and that would be the connection profile name. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services