You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/03/23 19:13:26 UTC

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #5173: Fix selection early termination test

Jackie-Jiang opened a new pull request #5173: Fix selection early termination test
URL: https://github.com/apache/incubator-pinot/pull/5173
 
 
   Credit to: siddharthteotia
   Replace: #5167

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #5173: Fix selection early termination test

Posted by GitBox <gi...@apache.org>.
Jackie-Jiang merged pull request #5173: Fix selection early termination test
URL: https://github.com/apache/incubator-pinot/pull/5173
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #5173: Fix selection early termination test

Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #5173: Fix selection early termination test
URL: https://github.com/apache/incubator-pinot/pull/5173#issuecomment-602801843
 
 
   Replace #5167 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #5173: Fix selection early termination test

Posted by GitBox <gi...@apache.org>.
mcvsubbu commented on a change in pull request #5173: Fix selection early termination test
URL: https://github.com/apache/incubator-pinot/pull/5173#discussion_r396746175
 
 

 ##########
 File path: pinot-core/src/test/java/org/apache/pinot/queries/SelectionOnlyEarlyTerminationTest.java
 ##########
 @@ -61,8 +62,13 @@ public void testSelectOnlyQuery() {
       assertNotNull(brokerResponse.getSelectionResults());
       assertNull(brokerResponse.getResultTable());
       assertEquals(brokerResponse.getNumSegmentsProcessed(), numSegmentsPerServer * NUM_SERVERS);
-      assertEquals(brokerResponse.getNumSegmentsMatched(), numThreadsPerServer * NUM_SERVERS);
-      assertEquals(brokerResponse.getNumDocsScanned(), numThreadsPerServer * NUM_SERVERS * limit);
+      // NOTE: 'numSegmentsMatched' and 'numDocsScanned' could be in a range because when the CombineOperator second
+      //       phase merge early terminates, the operators might not finish scanning the documents
+      long numSegmentsMatched = brokerResponse.getNumSegmentsMatched();
+      assertTrue(numSegmentsMatched >= NUM_SERVERS && numSegmentsMatched <= numThreadsPerServer * NUM_SERVERS);
+      long numDocsScanned = brokerResponse.getNumDocsScanned();
+      assertTrue(
+          numDocsScanned >= NUM_SERVERS * limit && numSegmentsMatched <= numThreadsPerServer * NUM_SERVERS * limit);
 
 Review comment:
   ```suggestion
             numDocsScanned >= NUM_SERVERS * limit && numDocsScanned <= numThreadsPerServer * NUM_SERVERS * limit);
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #5173: Fix selection early termination test

Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #5173: Fix selection early termination test
URL: https://github.com/apache/incubator-pinot/pull/5173#issuecomment-602849114
 
 
   @mcvsubbu Good catch!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #5173: Fix selection early termination test

Posted by GitBox <gi...@apache.org>.
mcvsubbu commented on a change in pull request #5173: Fix selection early termination test
URL: https://github.com/apache/incubator-pinot/pull/5173#discussion_r396746447
 
 

 ##########
 File path: pinot-core/src/test/java/org/apache/pinot/queries/SelectionOnlyEarlyTerminationTest.java
 ##########
 @@ -72,8 +78,13 @@ public void testSelectOnlyQuery() {
       assertNull(brokerResponse.getSelectionResults());
       assertNotNull(brokerResponse.getResultTable());
       assertEquals(brokerResponse.getNumSegmentsProcessed(), numSegmentsPerServer * NUM_SERVERS);
-      assertEquals(brokerResponse.getNumSegmentsMatched(), numThreadsPerServer * NUM_SERVERS);
-      assertEquals(brokerResponse.getNumDocsScanned(), numThreadsPerServer * NUM_SERVERS * limit);
+      // NOTE: 'numSegmentsMatched' and 'numDocsScanned' could be in a range because when the CombineOperator second
+      //       phase merge early terminates, the operators might not finish scanning the documents
+      numSegmentsMatched = brokerResponse.getNumSegmentsMatched();
+      assertTrue(numSegmentsMatched >= NUM_SERVERS && numSegmentsMatched <= numThreadsPerServer * NUM_SERVERS);
+      numDocsScanned = brokerResponse.getNumDocsScanned();
+      assertTrue(
+          numDocsScanned >= NUM_SERVERS * limit && numSegmentsMatched <= numThreadsPerServer * NUM_SERVERS * limit);
 
 Review comment:
   ```suggestion
             numDocsScanned >= NUM_SERVERS * limit && numDocsScanned <= numThreadsPerServer * NUM_SERVERS * limit);
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org