You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@flink.apache.org by flinker <fl...@126.com> on 2020/03/30 16:50:15 UTC

codestyle issue

Why are there unnecessary ';' lines in the code style of any files? For example, line 41 of the file Flink / Flink Runtime / SRC / main / Java / org / Apache / Flink / Runtime / client / clientutils.java.
Thanks.

Re:Re: codestyle issue

Posted by flinker <fl...@126.com>.

Concise and comprehensive.<br/>Thank you.
At 2020-03-31 09:45:35, "Xintong Song" <to...@gmail.com> wrote:
>Because it is a Enum. For java Enums, you need to first define its values,
>followed by a semicolon, then the methods. In this case, there's no values
>because we are only using Enum to keep ClientUtils singleton, but you still
>need the semicolon before defining methods. You could see that removing
>that semicolon will cause compiling errors.
>
>Thank you~
>
>Xintong Song
>
>
>
>On Tue, Mar 31, 2020 at 12:50 AM flinker <fl...@126.com> wrote:
>
>> Why are there unnecessary ';' lines in the code style of any files? For
>> example, line 41 of the file Flink / Flink Runtime / SRC / main / Java /
>> org / Apache / Flink / Runtime / client / clientutils.java.
>> Thanks.
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>

Re: codestyle issue

Posted by Xintong Song <to...@gmail.com>.

Because it is a Enum. For java Enums, you need to first define its values,
followed by a semicolon, then the methods. In this case, there's no values
because we are only using Enum to keep ClientUtils singleton, but you still
need the semicolon before defining methods. You could see that removing
that semicolon will cause compiling errors.

Thank you~

Xintong Song

On Tue, Mar 31, 2020 at 12:50 AM flinker <fl...@126.com> wrote:

> Why are there unnecessary ';' lines in the code style of any files? For
> example, line 41 of the file Flink / Flink Runtime / SRC / main / Java /
> org / Apache / Flink / Runtime / client / clientutils.java.
> Thanks.
>
>
>
>
>
>
>
>
>
>
>