You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/29 03:13:14 UTC

[GitHub] [spark] dengziming opened a new pull request, #39274: [SPARK-41760][BUILD][CONNECT] Enforce scalafmt for Connect Client module

dengziming opened a new pull request, #39274:
URL: https://github.com/apache/spark/pull/39274

   
   ### What changes were proposed in this pull request?
   1. This changes enables enforcing `scalafmt` for the Connect client module since it's a new module.
   2. This change applies `scalafmt` on the existing code-base.
   
   
   ### Why are the changes needed?
   Faster, focussed code reviews.
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   Faster, focussed code reviews.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on pull request #39274: [SPARK-41760][BUILD][CONNECT] Enforce scalafmt for Connect Client module

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #39274:
URL: https://github.com/apache/spark/pull/39274#issuecomment-1367713025

   thanks, merging to master!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] amaliujia commented on pull request #39274: [SPARK-41760][BUILD][CONNECT] Enforce scalafmt for Connect Client module

Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #39274:
URL: https://github.com/apache/spark/pull/39274#issuecomment-1367707196

   LGTM
   
   we have enforced this for the server so sounds good to do the same for client.
   
   cc @cloud-fan @hvanhovell 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan closed pull request #39274: [SPARK-41760][BUILD][CONNECT] Enforce scalafmt for Connect Client module

Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #39274: [SPARK-41760][BUILD][CONNECT] Enforce scalafmt for Connect Client module
URL: https://github.com/apache/spark/pull/39274


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org