[GitHub] [solr] HoustonPutman commented on a diff in pull request #1535: Update dependencies com.adobe.testing:s3mock-junit4 to v2.11.0, org.springframework.boot:spring-boot to 2.7.10, org.springframework:spring to 5.3.26, and software.amazon.awssdk to 2.19.1

["HoustonPutman (via GitHub)" <gi...@apache.org>]

HoustonPutman commented on code in PR #1535:
URL: https://github.com/apache/solr/pull/1535#discussion_r1156113644


##########
solr/modules/s3-repository/src/test/org/apache/solr/s3/S3PathsTest.java:
##########
@@ -48,7 +48,7 @@ public void testFiles() throws S3Exception {
   public void testDirectory() throws S3Exception {
 
     client.createDirectory("/simple-directory");
-    assertTrue(client.pathExists("/simple-directory"));
+    assertFalse("Dir path needs a trailing slash", client.pathExists("/simple-directory"));

Review Comment:
   Hmmm so it appears adobe mock no-longer supports this, but I'm pretty sure that S3 supports it... Kind of annoying.
   
   Not sure what this does with regards to test coverage... As long as the integration test works, I imagine we would be fine here....
   
   I'll try to run the nightlies on the module and see how it goes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org