You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by pietermartin <gi...@git.apache.org> on 2015/11/27 20:48:52 UTC
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-1000 Rollback the imp...
GitHub user pietermartin opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/159
TINKERPOP3-1000 Rollback the implicit transaction on multi threaded tests.
Tested on TinkerGraph, which does not support transactions.
Tested on Sqlg, which does support transactions, passes the test.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pietermartin/incubator-tinkerpop master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/159.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #159
----
commit 8bcebbaef66af670d9226be807a45943120d87c2
Author: pieter <pi...@gmail.com>
Date: 2015-11-27T19:42:51Z
Rollback the implicit transaction on multi threaded tests.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-1000 Rollback the imp...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/incubator-tinkerpop/pull/159#discussion_r46068829
--- Diff: gremlin-groovy-test/src/main/java/org/apache/tinkerpop/gremlin/groovy/jsr223/GremlinGroovyScriptEngineOverGraphTest.java ---
@@ -36,21 +36,10 @@
import javax.script.CompiledScript;
import javax.script.ScriptEngine;
import javax.script.ScriptException;
-import javax.script.SimpleBindings;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Random;
--- End diff --
as a matter of style, can you please amend your PR to not use wildcards?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-1000 Rollback the imp...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/159#issuecomment-160199453
I'll take the lead to merge this by CTR once that little issue of style is resolved. Thanks for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-1000 Rollback the imp...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/159
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-1000 Rollback the imp...
Posted by pietermartin <gi...@git.apache.org>.
Github user pietermartin commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/159#issuecomment-160251042
Not sure if I followed the correct procedure for updating a pull request as no notification was sent. However the amendment commit is on now on this pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: TINKERPOP3-1000 Rollback the imp...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/159#issuecomment-160720475
merged by CTR as this is pretty simple stuff - just adds a couple transaction management lines to the tests. thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---