You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/05/27 16:48:49 UTC

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #41319: [SPARK-43815][SQL] Add `to_varchar` alias for `to_char`

dongjoon-hyun commented on code in PR #41319:
URL: https://github.com/apache/spark/pull/41319#discussion_r1208061394


##########
sql/core/src/test/resources/sql-tests/inputs/charvarchar.sql:
##########
@@ -117,3 +117,10 @@ drop table char_tbl4;
 -- ascii value for Latin-1 Supplement characters
 select ascii('§'), ascii('÷'), ascii('×10');
 select chr(167), chr(247), chr(215);
+
+-- [SPARK-43815] Add to_varchar alias for to_char
+-- TO_VARCHAR()
+-- Alias of TO_CHAR()

Review Comment:
   These three lines look repeating. Could you simply the above three lines into a single liner? Maybe, like the following?
   ```
   -- to_varchar is an alias for to_char
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org