You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/11/19 17:58:56 UTC

[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2818: [GOBBLIN-963] Remove duplicated copies of TaskContext/TaskState when constructing TaskIFaceWrapper

sv2000 commented on a change in pull request #2818: [GOBBLIN-963] Remove duplicated copies of TaskContext/TaskState when constructing TaskIFaceWrapper
URL: https://github.com/apache/incubator-gobblin/pull/2818#discussion_r348078839
 
 

 ##########
 File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/GobblinMultiTaskAttempt.java
 ##########
 @@ -78,8 +78,7 @@
     /**
      * Commit {@link GobblinMultiTaskAttempt} immediately after running is done.
      */
-    IMMEDIATE,
-    /**
+    IMMEDIATE, /**
 
 Review comment:
   Is this intentional? Shouldn't the "/**" start on a new line?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services