You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2016/03/17 08:27:54 UTC

[GitHub] storm pull request: STORM-1602 Blobstore UTs are failed on Windows

GitHub user HeartSaVioR opened a pull request:

    https://github.com/apache/storm/pull/1227

    STORM-1602 Blobstore UTs are failed on Windows

    * ensures objects of InputStream / OutputStream are closed after used
      * clojure: with-open
      * java: try-with-resource
    * skip checking symbolic link in LocalizerTest when on Windows
      * Windows seems not handle symbolic link in compressed file properly
    
    Some integration tests are still failing on Windows, but it should be handled with another issues.
    
    I'll also address this based on master immediately.
    
    Please have a look. Thanks!

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HeartSaVioR/storm STORM-1602-1.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1227.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1227
    
----
commit 8965a6c2459841c607fb9587897502581f1e3cdf
Author: Jungtaek Lim <ka...@gmail.com>
Date:   2016-03-17T06:53:15Z

    STORM-1602 Blobstore UTs are failed on Windows
    
    * ensures objects of InputStream / OutputStream are closed after using
      * clojure: with-open
      * java: try-with-resource
    * skip checking symbolic link in LocalizerTest when on Windows
      * Windows seems not handle symbolic link in compressed file properly

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-1602 Blobstore UTs are failed on Windows

Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:

    https://github.com/apache/storm/pull/1227#issuecomment-198153364
  
    @revans2 Very odd indeed... It should give us error because of storm-mongo module.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-1602 Blobstore UTs are failed on Windows

Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:

    https://github.com/apache/storm/pull/1227#issuecomment-197760146
  
    #1229 is based on master branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-1602 Blobstore UTs are failed on Windows

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/1227


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-1602 Blobstore UTs are failed on Windows

Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/1227#issuecomment-197885702
  
    I assume they all pass on windows so +1
    
    The test failure looks like it is a bug with the mongodb pom.xml that JDK8 does not like but JDK7 seems OK with.  Very odd.  Filed a JIRA for it though.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-1602 Blobstore UTs are failed on Windows

Posted by redsanket <gi...@git.apache.org>.
Github user redsanket commented on the pull request:

    https://github.com/apache/storm/pull/1227#issuecomment-198032722
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---