You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficcontrol.apache.org by de...@apache.org on 2018/04/10 18:48:45 UTC

[incubator-trafficcontrol] branch master updated: fixes api tests for ds_requests where route params were removed in favor of query params

This is an automated email from the ASF dual-hosted git repository.

dewrich pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-trafficcontrol.git


The following commit(s) were added to refs/heads/master by this push:
     new 1a2ef4a  fixes api tests for ds_requests where route params were removed in favor of query params
1a2ef4a is described below

commit 1a2ef4a0da6c9a88eb7ff09b73b5f180cdb4c022
Author: Jeremy Mitchell <mi...@gmail.com>
AuthorDate: Tue Apr 10 12:43:45 2018 -0600

    fixes api tests for ds_requests where route params were removed in favor of query params
---
 traffic_ops/client/v13/deliveryservice_request_comments.go | 6 +++---
 traffic_ops/client/v13/deliveryservice_requests.go         | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/traffic_ops/client/v13/deliveryservice_request_comments.go b/traffic_ops/client/v13/deliveryservice_request_comments.go
index c168dc4..02e0763 100644
--- a/traffic_ops/client/v13/deliveryservice_request_comments.go
+++ b/traffic_ops/client/v13/deliveryservice_request_comments.go
@@ -59,7 +59,7 @@ func (to *Session) UpdateDeliveryServiceRequestCommentByID(id int, comment tc.De
 	if err != nil {
 		return tc.Alerts{}, reqInf, err
 	}
-	route := fmt.Sprintf("%s/%d", API_v13_DeliveryServiceRequestComments, id)
+	route := fmt.Sprintf("%s?id=%d", API_v13_DeliveryServiceRequestComments, id)
 	resp, remoteAddr, err := to.request(http.MethodPut, route, reqBody)
 	if err != nil {
 		return tc.Alerts{}, reqInf, err
@@ -86,7 +86,7 @@ func (to *Session) GetDeliveryServiceRequestComments() ([]tc.DeliveryServiceRequ
 
 // GET a delivery service request comment by ID
 func (to *Session) GetDeliveryServiceRequestCommentByID(id int) ([]tc.DeliveryServiceRequestComment, ReqInf, error) {
-	route := fmt.Sprintf("%s/%d", API_v13_DeliveryServiceRequestComments, id)
+	route := fmt.Sprintf("%s?id=%d", API_v13_DeliveryServiceRequestComments, id)
 	resp, remoteAddr, err := to.request(http.MethodGet, route, nil)
 	reqInf := ReqInf{CacheHitStatus: CacheHitStatusMiss, RemoteAddr: remoteAddr}
 	if err != nil {
@@ -104,7 +104,7 @@ func (to *Session) GetDeliveryServiceRequestCommentByID(id int) ([]tc.DeliverySe
 
 // DELETE a delivery service request comment by ID
 func (to *Session) DeleteDeliveryServiceRequestCommentByID(id int) (tc.Alerts, ReqInf, error) {
-	route := fmt.Sprintf("%s/%d", API_v13_DeliveryServiceRequestComments, id)
+	route := fmt.Sprintf("%s?id=%d", API_v13_DeliveryServiceRequestComments, id)
 	resp, remoteAddr, err := to.request(http.MethodDelete, route, nil)
 	reqInf := ReqInf{CacheHitStatus: CacheHitStatusMiss, RemoteAddr: remoteAddr}
 	if err != nil {
diff --git a/traffic_ops/client/v13/deliveryservice_requests.go b/traffic_ops/client/v13/deliveryservice_requests.go
index 2bf3bec..7b8689e 100644
--- a/traffic_ops/client/v13/deliveryservice_requests.go
+++ b/traffic_ops/client/v13/deliveryservice_requests.go
@@ -98,7 +98,7 @@ func (to *Session) GetDeliveryServiceRequestByXMLID(XMLID string) ([]tc.Delivery
 
 // GET a DeliveryServiceRequest by the DeliveryServiceRequest id
 func (to *Session) GetDeliveryServiceRequestByID(id int) ([]tc.DeliveryServiceRequest, ReqInf, error) {
-	route := fmt.Sprintf("%s/%d", API_DS_REQUESTS, id)
+	route := fmt.Sprintf("%s?id=%d", API_DS_REQUESTS, id)
 	resp, remoteAddr, err := to.request(http.MethodGet, route, nil)
 	reqInf := ReqInf{CacheHitStatus: CacheHitStatusMiss, RemoteAddr: remoteAddr}
 	if err != nil {
@@ -119,7 +119,7 @@ func (to *Session) GetDeliveryServiceRequestByID(id int) ([]tc.DeliveryServiceRe
 // Update a DeliveryServiceRequest by ID
 func (to *Session) UpdateDeliveryServiceRequestByID(id int, dsr tc.DeliveryServiceRequest) (tc.Alerts, ReqInf, error) {
 
-	route := fmt.Sprintf("%s/%d", API_DS_REQUESTS, id)
+	route := fmt.Sprintf("%s?id=%d", API_DS_REQUESTS, id)
 
 	var remoteAddr net.Addr
 	reqBody, err := json.Marshal(dsr)
@@ -139,7 +139,7 @@ func (to *Session) UpdateDeliveryServiceRequestByID(id int, dsr tc.DeliveryServi
 
 // DELETE a DeliveryServiceRequest by DeliveryServiceRequest assignee
 func (to *Session) DeleteDeliveryServiceRequestByID(id int) (tc.Alerts, ReqInf, error) {
-	route := fmt.Sprintf("%s/%d", API_DS_REQUESTS, id)
+	route := fmt.Sprintf("%s?id=%d", API_DS_REQUESTS, id)
 	resp, remoteAddr, err := to.rawRequest(http.MethodDelete, route, nil)
 	reqInf := ReqInf{CacheHitStatus: CacheHitStatusMiss, RemoteAddr: remoteAddr}
 	if err != nil {

-- 
To stop receiving notification emails like this one, please contact
dewrich@apache.org.