You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by walterddr <gi...@git.apache.org> on 2018/05/04 15:44:04 UTC

[GitHub] flink issue #5940: [FLINK-8690][table]Support group window distinct aggregat...

Github user walterddr commented on the issue:

    https://github.com/apache/flink/pull/5940
  
    Thanks @suez1224 @fhueske for the comments. I will change them accordingly. 
    
    Yes I copied a lot of test cases from @haohui's PR for my own testing. I can definitely put it on top given the runtime support is already merged in #5555. Procedure-wise question: should I rebase his commit then add my change on top, then attached to this PR? I am not sure if there's a clever way to both preserve the discussion in this thread and rebase on top of his change.


---