[GitHub] [incubator-kyuubi] iodone commented on pull request #1853: [KYUUBI #1798] Add EventBus module to unify the distribution and subscription of Kyuubi's events

[GitBox <gi...@apache.org>]

iodone commented on pull request #1853:
URL: https://github.com/apache/incubator-kyuubi/pull/1853#issuecomment-1033433258


   > > cc @wForget, can you help check this PR?
   > 
   > Sorry, I'm confused about this, this is overcorrect for my needs. For me, I just need to store the event asynchronously and don't need to add some handlers to handle it when producing events. I will read the event in storage(like es), then process and audit it.
   > 
   > In addition, I feel this is similar to before:
   > 
   > 1. EventBus is similar to EventLoggingService
   > 2. EventHandler is similar to EventLogger
   
   @wForget The motivation for the implementation of eventBus can be found in #1798 
   
   EventBus is just a Handler for triggering and adding events, it does not contain any business logic, EventLoggerService can be seen as a concrete business implementation of one of these Handlers. Because the previous EventLoggerService implementation was slightly complex and coupled, it was adapted using EventBus in order to be compatible with the previous implementation logic, and at the same time, it is very clear and simple to use EventBus.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org