[GitHub] [spark] brkyvz commented on a change in pull request #26771: [SPARK-30143][SS] Add a timeout on stopping a streaming query

[GitBox <gi...@apache.org>]

brkyvz commented on a change in pull request #26771: [SPARK-30143][SS] Add a timeout on stopping a streaming query
URL: https://github.com/apache/spark/pull/26771#discussion_r355145637
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
 ##########
 @@ -1258,6 +1258,14 @@ object SQLConf {
       .timeConf(TimeUnit.MILLISECONDS)
       .createWithDefault(10L)
 
+  val STREAMING_STOP_TIMEOUT =
+    buildConf("spark.sql.streaming.stopTimeout")
+      .doc("How long to wait for the streaming execution thread to stop when calling the " +
+        "streaming query's stop() method in milliseconds. 0 means to wait infinitely. Setting a " +
 
 Review comment:
   Sometimes it would fail in a case where it is very hard to debug though. A creation of a SparkSession may fail because of the poorly set parameters, which makes it harder to debug. Therefore we're a lot more lenient with the setting of bad configurations.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org