You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "carols10cents (via GitHub)" <gi...@apache.org> on 2025/12/12 20:54:06 UTC
[PR] fix: Add more details on what isn't implemented [arrow-rs-object-store]
carols10cents opened a new pull request, #575:
URL: https://github.com/apache/arrow-rs-object-store/pull/575
# Which issue does this PR close?
Closes #572.
# Rationale for this change
When a user has lots of uses of object_store and one of them is returning `object_store::Error::NotImplemented`, provide more information to make debugging easier.
# What changes are included in this PR?
I added 2 fields to `NotImplemented`: a description of what operation isn't implemented and which implementation is returning this.
# Are there any user-facing changes?
**This is a breaking change to the public API of the `object_store::Error` type.**
Because of the additional fields on the error variant, if anyone is matching on this variant, they'll likely have to update their code. If any implementers of this trait are returning this error, they'll have to update their construction of this variant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Add fields to `Error::NotImplemented` with more details on what isn't implemented [arrow-rs-object-store]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #575:
URL: https://github.com/apache/arrow-rs-object-store/pull/575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: Add fields to `Error::NotImplemented` with more details on what isn't implemented [arrow-rs-object-store]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #575:
URL: https://github.com/apache/arrow-rs-object-store/pull/575#issuecomment-3671498453
Thank you @carols10cents and @kylebarron
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org