You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/03/17 17:44:17 UTC
[GitHub] [incubator-mxnet] hanke580 opened a new pull request #17857:
[Numpy] FFI: sort, argsort, vstack
hanke580 opened a new pull request #17857: [Numpy] FFI: sort, argsort, vstack
URL: https://github.com/apache/incubator-mxnet/pull/17857
## Description ##
(Brief description on what this PR is about)
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
- Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
- [ ] Code is well-documented:
- For user-facing API changes, API doc string has been updated.
- For new C++ functions in header files, their functionalities and arguments are documented.
- For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
- Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
- [ ] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] hanke580 commented on issue #17857: [Numpy] FFI:
sort, argsort, vstack
Posted by GitBox <gi...@apache.org>.
hanke580 commented on issue #17857: [Numpy] FFI: sort, argsort, vstack
URL: https://github.com/apache/incubator-mxnet/pull/17857#issuecomment-603175157
@mxnet-bot run ci [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] hanke580 edited a comment on issue #17857:
[Numpy] FFI: sort, argsort, vstack
Posted by GitBox <gi...@apache.org>.
hanke580 edited a comment on issue #17857: [Numpy] FFI: sort, argsort, vstack
URL: https://github.com/apache/incubator-mxnet/pull/17857#issuecomment-603244907
@mxnet-bot run ci windows-gpu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17857: [Numpy] FFI:
sort, argsort, vstack
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17857: [Numpy] FFI: sort, argsort, vstack
URL: https://github.com/apache/incubator-mxnet/pull/17857#issuecomment-603247327
Undefined action detected.
Permissible actions are : run ci [all], run ci [job1, job2]
Example : @mxnet-bot run ci [all]
Example : @mxnet-bot run ci [centos-cpu, clang]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] hanke580 commented on pull request #17857: [Numpy] FFI: sort, argsort, vstack etc
Posted by GitBox <gi...@apache.org>.
hanke580 commented on pull request #17857:
URL: https://github.com/apache/incubator-mxnet/pull/17857#issuecomment-664055414
@mxnet-bot run ci [all]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] hanke580 commented on issue #17857: [Numpy] FFI:
sort, argsort, vstack
Posted by GitBox <gi...@apache.org>.
hanke580 commented on issue #17857: [Numpy] FFI: sort, argsort, vstack
URL: https://github.com/apache/incubator-mxnet/pull/17857#issuecomment-604294962
@mxnet-bot run ci [unix-gpu, centos-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] hanke580 edited a comment on issue #17857:
[Numpy] FFI: sort, argsort, vstack
Posted by GitBox <gi...@apache.org>.
hanke580 edited a comment on issue #17857: [Numpy] FFI: sort, argsort, vstack
URL: https://github.com/apache/incubator-mxnet/pull/17857#issuecomment-603244907
@mxnet-bot run ci [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] hanke580 commented on issue #17857: [Numpy] FFI:
sort, argsort, vstack
Posted by GitBox <gi...@apache.org>.
hanke580 commented on issue #17857: [Numpy] FFI: sort, argsort, vstack
URL: https://github.com/apache/incubator-mxnet/pull/17857#issuecomment-603627959
@mxnet-bot run ci [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17857: [Numpy] FFI:
sort, argsort, vstack
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17857: [Numpy] FFI: sort, argsort, vstack
URL: https://github.com/apache/incubator-mxnet/pull/17857#issuecomment-604295036
Jenkins CI successfully triggered : [unix-gpu, centos-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] hanke580 removed a comment on issue #17857:
[Numpy] FFI: sort, argsort, vstack
Posted by GitBox <gi...@apache.org>.
hanke580 removed a comment on issue #17857: [Numpy] FFI: sort, argsort, vstack
URL: https://github.com/apache/incubator-mxnet/pull/17857#issuecomment-603175157
@mxnet-bot run ci [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] hanke580 commented on issue #17857: [Numpy] FFI:
sort, argsort, vstack
Posted by GitBox <gi...@apache.org>.
hanke580 commented on issue #17857: [Numpy] FFI: sort, argsort, vstack
URL: https://github.com/apache/incubator-mxnet/pull/17857#issuecomment-603244907
@mxnet-bot run ci [windows-gpu, unix-gpu, centos-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] hzfan commented on a change in pull request
#17857: [Numpy] FFI: sort, argsort, vstack
Posted by GitBox <gi...@apache.org>.
hzfan commented on a change in pull request #17857: [Numpy] FFI: sort, argsort, vstack
URL: https://github.com/apache/incubator-mxnet/pull/17857#discussion_r399910952
##########
File path: src/api/operator/numpy/np_ordering_op.cc
##########
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*!
+ * \file np_ordering_op.cc
+ * \brief Implementation of the API of functions in src/operator/tensor/ordering_op.cc
+ */
+#include <mxnet/api_registry.h>
+#include <mxnet/runtime/packed_func.h>
+#include "../utils.h"
+#include "../../../operator/tensor/ordering_op-inl.h"
+
+namespace mxnet {
+
+MXNET_REGISTER_API("_npi.sort")
+.set_body([](runtime::MXNetArgs args, runtime::MXNetRetValue* ret) {
+ using namespace runtime;
+ const nnvm::Op* op = Op::Get("_npi_sort");
+ nnvm::NodeAttrs attrs;
+ op::SortParam param;
+
+ if (args[1].type_code() == kNull) {
+ param.axis = dmlc::nullopt;
+ } else {
+ param.axis = args[1].operator int();
+ }
+ param.is_ascend = true;
+
+ attrs.parsed = std::move(param);
+ attrs.op = op;
+
+ int num_inputs = 1;
+ NDArray* inputs[] = {args[0].operator mxnet::NDArray*()};
+
+ int num_outputs = 0;
+ SetAttrDict<op::SortParam>(&attrs);
+ auto ndoutputs = Invoke(op, &attrs, num_inputs, inputs, &num_outputs, nullptr);
+ *ret = reinterpret_cast<mxnet::NDArray*>(ndoutputs[0]);
+});
+
+MXNET_REGISTER_API("_npi.argsort")
+.set_body([](runtime::MXNetArgs args, runtime::MXNetRetValue* ret) {
+ using namespace runtime;
+ const nnvm::Op* op = Op::Get("_npi_argsort");
+ nnvm::NodeAttrs attrs;
+ op::ArgSortParam param;
+
+ if (args[1].type_code() == kNull) {
+ param.axis = dmlc::nullopt;
+ } else {
+ param.axis = args[1].operator int();
+ }
+ param.is_ascend = true;
+ if (args[3].type_code() == kNull) {
+ param.dtype = mshadow::kFloat32;
Review comment:
Default value seems to be `kInt64`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17857: [Numpy] FFI:
sort, argsort, vstack
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17857: [Numpy] FFI: sort, argsort, vstack
URL: https://github.com/apache/incubator-mxnet/pull/17857#issuecomment-603627998
Jenkins CI successfully triggered : [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] hanke580 removed a comment on issue #17857:
[Numpy] FFI: sort, argsort, vstack
Posted by GitBox <gi...@apache.org>.
hanke580 removed a comment on issue #17857: [Numpy] FFI: sort, argsort, vstack
URL: https://github.com/apache/incubator-mxnet/pull/17857#issuecomment-603244907
@mxnet-bot run ci [windows-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] hanke580 commented on issue #17857: [Numpy] FFI: sort, argsort, vstack etc
Posted by GitBox <gi...@apache.org>.
hanke580 commented on issue #17857:
URL: https://github.com/apache/incubator-mxnet/pull/17857#issuecomment-617070733
@mxnet-bot run ci [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] hanke580 commented on issue #17857: [Numpy] FFI: sort, argsort, vstack etc
Posted by GitBox <gi...@apache.org>.
hanke580 commented on issue #17857:
URL: https://github.com/apache/incubator-mxnet/pull/17857#issuecomment-618155536
@mxnet-bot run ci [unix-gpu, unix-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17857: [Numpy] FFI: sort, argsort, vstack etc
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17857:
URL: https://github.com/apache/incubator-mxnet/pull/17857#issuecomment-618155573
Jenkins CI successfully triggered : [unix-cpu, unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] hzfan commented on pull request #17857: [Numpy] FFI: sort, argsort, vstack etc
Posted by GitBox <gi...@apache.org>.
hzfan commented on pull request #17857:
URL: https://github.com/apache/incubator-mxnet/pull/17857#issuecomment-671160282
Thanks @hanke580 @yzhliu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] hzfan merged pull request #17857: [Numpy] FFI: sort, argsort, vstack etc
Posted by GitBox <gi...@apache.org>.
hzfan merged pull request #17857:
URL: https://github.com/apache/incubator-mxnet/pull/17857
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] hanke580 commented on a change in pull request #17857: [Numpy] FFI: sort, argsort, vstack etc
Posted by GitBox <gi...@apache.org>.
hanke580 commented on a change in pull request #17857:
URL: https://github.com/apache/incubator-mxnet/pull/17857#discussion_r444793439
##########
File path: src/api/operator/numpy/np_elemwise_broadcast_logic_op.cc
##########
@@ -71,4 +71,12 @@ MXNET_REGISTER_API("_npi.less_equal")
UFuncHelper(args, ret, op, op_scalar, op_rscalar);
});
+MXNET_REGISTER_API("_npi.greater")
+.set_body([](runtime::MXNetArgs args, runtime::MXNetRetValue* ret) {
+ using namespace runtime;
+ const nnvm::Op* op = Op::Get("_npi_greater");
+ const nnvm::Op* op_scalar = Op::Get("_npi_greater_scalar");
+ UFuncHelper(args, ret, op, op_scalar, nullptr);
Review comment:
Fixed Thx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17857: [Numpy] FFI: sort, argsort, vstack etc
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17857:
URL: https://github.com/apache/incubator-mxnet/pull/17857#issuecomment-617070801
Jenkins CI successfully triggered : [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] hzfan commented on a change in pull request #17857: [Numpy] FFI: sort, argsort, vstack etc
Posted by GitBox <gi...@apache.org>.
hzfan commented on a change in pull request #17857:
URL: https://github.com/apache/incubator-mxnet/pull/17857#discussion_r418041632
##########
File path: src/api/operator/numpy/np_elemwise_broadcast_logic_op.cc
##########
@@ -71,4 +71,12 @@ MXNET_REGISTER_API("_npi.less_equal")
UFuncHelper(args, ret, op, op_scalar, op_rscalar);
});
+MXNET_REGISTER_API("_npi.greater")
+.set_body([](runtime::MXNetArgs args, runtime::MXNetRetValue* ret) {
+ using namespace runtime;
+ const nnvm::Op* op = Op::Get("_npi_greater");
+ const nnvm::Op* op_scalar = Op::Get("_npi_greater_scalar");
+ UFuncHelper(args, ret, op, op_scalar, nullptr);
Review comment:
`greater` is not a commutative operator, the last argument should not be `nullptr`.
##########
File path: src/api/operator/numpy/np_matrix_op.cc
##########
@@ -467,4 +467,24 @@ MXNET_REGISTER_API("_npi.diag_indices_from")
*ret = ndoutputs[0];
});
+MXNET_REGISTER_API("_npi.vstack")
+.set_body([](runtime::MXNetArgs args, runtime::MXNetRetValue* ret) {
+ using namespace runtime;
+ const nnvm::Op* op = Op::Get("_npi_vstack");
+ nnvm::NodeAttrs attrs;
+ op::NumpyVstackParam param;
+ param.num_args = args.size();
+
+ attrs.parsed = param;
+ attrs.op = op;
+ SetAttrDict<op::NumpyVstackParam>(&attrs);
+ int num_outputs = 0;
+ std::vector<NDArray*> inputs;
+ for (int i = 0; i < param.num_args; ++i) {
+ inputs.push_back(args[i].operator mxnet::NDArray*());
+ }
+ auto ndoutputs = Invoke(op, &attrs, param.num_args, &inputs[0], &num_outputs, nullptr);
Review comment:
Please avoid `inputs[0]` because there is no guarantee that it ever exists. I think there will be some standard (and safer) ways to get the address of vector data.
##########
File path: src/api/operator/numpy/random/np_multinomial_op.cc
##########
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*!
+ * \file np_multinomial_op.cc
+ * \brief Implementation of the API of functions in src/operator/numpy/random/np_multinomial_op.cc
+ */
+#include <mxnet/api_registry.h>
+#include <mxnet/runtime/packed_func.h>
+#include <vector>
+#include "../../utils.h"
+#include "../../../../operator/numpy/random/np_multinomial_op.h"
+
+namespace mxnet {
+
+MXNET_REGISTER_API("_npi.multinomial")
+.set_body([](runtime::MXNetArgs args, runtime::MXNetRetValue* ret) {
+ using namespace runtime;
+ const nnvm::Op* op = Op::Get("_npi_multinomial");
+ nnvm::NodeAttrs attrs;
+ op::NumpyMultinomialParam param;
+ std::vector<NDArray*> inputs;
+
+ // parse int
+ param.n = args[0].operator int();
+
+ // parse pvals
+ if (args[1].type_code() == kNull) {
+ param.pvals = dmlc::nullopt;
Review comment:
Note that `pvals` can be `NDArray`, please handle this case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] hanke580 commented on issue #17857: [Numpy] FFI: sort, argsort, vstack etc
Posted by GitBox <gi...@apache.org>.
hanke580 commented on issue #17857:
URL: https://github.com/apache/incubator-mxnet/pull/17857#issuecomment-616914046
@mxnet-bot run ci [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #17857: [Numpy] FFI: sort, argsort, vstack etc
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #17857:
URL: https://github.com/apache/incubator-mxnet/pull/17857#issuecomment-620384004
Jenkins CI successfully triggered : [sanity]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #17857: [Numpy] FFI: sort, argsort, vstack etc
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #17857:
URL: https://github.com/apache/incubator-mxnet/pull/17857#issuecomment-616914079
Jenkins CI successfully triggered : [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] hanke580 commented on pull request #17857: [Numpy] FFI: sort, argsort, vstack etc
Posted by GitBox <gi...@apache.org>.
hanke580 commented on pull request #17857:
URL: https://github.com/apache/incubator-mxnet/pull/17857#issuecomment-620383981
@mxnet-bot run ci [sanity]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #17857: [Numpy] FFI: sort, argsort, vstack etc
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #17857:
URL: https://github.com/apache/incubator-mxnet/pull/17857#issuecomment-664055432
Jenkins CI successfully triggered : [centos-gpu, centos-cpu, miscellaneous, clang, unix-cpu, unix-gpu, windows-gpu, sanity, website, edge, windows-cpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org