[GitHub] [metron] ruffle1986 edited a comment on issue #1527: METRON-2276: [UI] Performance: Switching back from manual filtering fires a "full query"

[GitBox <gi...@apache.org>]

ruffle1986 edited a comment on issue #1527: METRON-2276: [UI] Performance: Switching back from manual filtering fires a "full query"
URL: https://github.com/apache/metron/pull/1527#issuecomment-539500257
 
 
   @sardell The effort is huge already if you want to maintain the things around the query builder. I'm working on saving the manual query into local storage and I'm spending hours to figure what's going on. For the record, it has nothing to do with the conversion stuff. The main reason is having these things poorly implemented at the fundamentals. It's a good example why it hurts if we have multiple components and services tied together and everybody changes everybody's internal state.
   I would maintain the manual mode and the query builder separately in order to make it easier to focus on smaller chunks. Yes I understand that we're trying to re-use already existing code but I think it's a common mistake here and harmful to follow the DRY principle. We're adding more code in order to cover different edge cases and it's getting harder to maintain and understand.
   I highly recommend to allocate some time to refactor the "search section". I've also heard rumours about getting rid of the query builder and only allow users to type their own lucine queries manually.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services