[GitHub] [netbeans] tmysik commented on a diff in pull request #5725: Don't show documentation for an empty line #5347

["tmysik (via GitHub)" <gi...@apache.org>]

tmysik commented on code in PR #5725:
URL: https://github.com/apache/netbeans/pull/5725#discussion_r1149550099


##########
php/php.editor/test/unit/src/org/netbeans/modules/php/editor/completion/PHPCCDocumentationTest.java:
##########
@@ -354,7 +364,21 @@ public void checkCompletionDocumentation(final String file, final String caretLi
     }
 
     private void checkCompletionOnlyDocumentation(String filePath, String caretLine) throws Exception {
-        checkCompletionDocumentation(filePath, caretLine, false, "", QueryType.DOCUMENTATION);
+        checkCompletionOnlyDocumentation(filePath, caretLine, false);
+    }
+
+    private void checkCompletionOnlyDocumentation(String filePath, String caretLine, boolean noDocument) throws Exception {
+        if (!noDocument) {
+            checkCompletionDocumentation(filePath, caretLine, false, "", QueryType.DOCUMENTATION);
+        } else {
+            try {
+                checkCompletionDocumentation(filePath, caretLine, false, "", QueryType.DOCUMENTATION);
+            } catch (AssertionError ex) {
+                // there is no completion item
+                return;
+            }

Review Comment:
   Do we want to change/fix `CslTestBase`? 🤔 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists