[GitHub] [incubator-superset] nytai edited a comment on pull request #10070: fix: use custom int parsing over flask int parsing in sqllab queries endpoint

[GitBox <gi...@apache.org>]

nytai edited a comment on pull request #10070:
URL: https://github.com/apache/incubator-superset/pull/10070#issuecomment-644922204


   @john-bodley We could, but since javascript doesn't really have integer support it's likely that these requests will happen again sooner or later. In either case I'm not sure 404 is what we want to do in this case, it's rather confusing from a client perspective. A 400 (bad request) would make more sense. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org