You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/04/17 04:03:31 UTC

[Impala-ASF-CR] IMPALA-7995: print webpage to debug test failure

Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13052


Change subject: IMPALA-7995: print webpage to debug test failure
......................................................................

IMPALA-7995: print webpage to debug test failure

TestWebPage::test_catalog failed on a test run. Printing the response
test will help debug in future.

Change-Id: I0425aa9cb173548e47377c5738c0cb070c21fd87
---
M tests/webserver/test_web_pages.py
1 file changed, 3 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/52/13052/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13052
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0425aa9cb173548e47377c5738c0cb070c21fd87
Gerrit-Change-Number: 13052
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-7995: print webpage to debug test failure

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13052 )

Change subject: IMPALA-7995: print webpage to debug test failure
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/13052
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0425aa9cb173548e47377c5738c0cb070c21fd87
Gerrit-Change-Number: 13052
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Apr 2019 09:14:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7995: print webpage to debug test failure

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13052 )

Change subject: IMPALA-7995: print webpage to debug test failure
......................................................................


Patch Set 1: Code-Review+2

This is so trivial I'm just going to +2 myself


-- 
To view, visit http://gerrit.cloudera.org:8080/13052
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0425aa9cb173548e47377c5738c0cb070c21fd87
Gerrit-Change-Number: 13052
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Apr 2019 04:04:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7995: print webpage to debug test failure

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13052 )

Change subject: IMPALA-7995: print webpage to debug test failure
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/2812/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13052
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0425aa9cb173548e47377c5738c0cb070c21fd87
Gerrit-Change-Number: 13052
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Apr 2019 04:47:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-7995: print webpage to debug test failure

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13052 )

Change subject: IMPALA-7995: print webpage to debug test failure
......................................................................

IMPALA-7995: print webpage to debug test failure

TestWebPage::test_catalog failed on a test run. Printing the response
test will help debug in future.

Change-Id: I0425aa9cb173548e47377c5738c0cb070c21fd87
Reviewed-on: http://gerrit.cloudera.org:8080/13052
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/webserver/test_web_pages.py
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/13052
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0425aa9cb173548e47377c5738c0cb070c21fd87
Gerrit-Change-Number: 13052
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-7995: print webpage to debug test failure

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13052 )

Change subject: IMPALA-7995: print webpage to debug test failure
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4030/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/13052
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0425aa9cb173548e47377c5738c0cb070c21fd87
Gerrit-Change-Number: 13052
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Apr 2019 04:04:27 +0000
Gerrit-HasComments: No