You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/02/01 18:22:46 UTC
[GitHub] clintropolis commented on a change in pull request #6971: Added
checkstyle for "Methods starting with Capital Letters"
clintropolis commented on a change in pull request #6971: Added checkstyle for "Methods starting with Capital Letters"
URL: https://github.com/apache/incubator-druid/pull/6971#discussion_r253149585
##########
File path: sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java
##########
@@ -133,15 +133,15 @@ public void testSelectCountStart() throws Exception
CalciteTests.REGULAR_USER_AUTH_RESULT,
ImmutableList.of(Druids.newTimeseriesQueryBuilder()
.dataSource(CalciteTests.DATASOURCE1)
- .intervals(QSS(Filtration.eternity()))
- .filters(SELECTOR("dim2", "0", null))
+ .intervals(qss(Filtration.eternity()))
Review comment:
Hmm, so I think I actually prefer these test shorthand methods as ALLCAPS instead of lowercase, makes it to parse for me at least. Was the intention to disallow all uppercase static methods too or just methods that started with an uppercase letter and were not fully uppercase?
If no one agrees with me feel free to disregard this review 🙃
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org