You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/08/16 15:21:01 UTC
[GitHub] yanghua commented on a change in pull request #6557: [FLINK-10149]
[flink-mesos] Don't allocate extra mesos port for TM unless configured to
do so.
yanghua commented on a change in pull request #6557: [FLINK-10149] [flink-mesos] Don't allocate extra mesos port for TM unless configured to do so.
URL: https://github.com/apache/flink/pull/6557#discussion_r210638112
##########
File path: flink-mesos/src/main/java/org/apache/flink/mesos/configuration/MesosOptions.java
##########
@@ -137,7 +137,7 @@
* Config parameter to configure which configuration keys will dynamically get a port assigned through Mesos.
*/
public static final ConfigOption<String> PORT_ASSIGNMENTS = key("mesos.resourcemanager.tasks.port-assignments")
Review comment:
change :
```java
public static final ConfigOption<String> PORT_ASSIGNMENTS = key("mesos.resourcemanager.tasks.port-assignments")
```
to :
```java
public static final ConfigOption<String> PORT_ASSIGNMENTS =
key("mesos.resourcemanager.tasks.port-assignments")
```
let it match other configuration item's style, looks better to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services