[GitHub] [kafka] showuon commented on a diff in pull request #13584: MINOR: Add log segment unit tests, If the maximum offset beyond index, appen…

["showuon (via GitHub)" <gi...@apache.org>]

showuon commented on code in PR #13584:
URL: https://github.com/apache/kafka/pull/13584#discussion_r1188050289


##########
core/src/test/scala/unit/kafka/log/LogSegmentTest.scala:
##########
@@ -65,6 +68,29 @@ class LogSegmentTest {
     Utils.delete(logDir)
   }
 
+  /**
+   * If the maximum offset beyond index, appended to the log section, it throws LogSegmentOffsetOverflowException

Review Comment:
   This comment is not clear enough (ex: what is maximum offset mean in this test?). Maybe:
   ```
   LogSegmentOffsetOverflowException should be thrown while appending the logs if:
   1. largestOffset - baseOffset < 0
   2. largestOffset - baseOffset > Integer.MAX_VALUE
   ``` 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org