You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/22 04:29:29 UTC
[GitHub] [arrow] vibhatha opened a new pull request #12685: [MINOR]: Minor comment fix
vibhatha opened a new pull request #12685:
URL: https://github.com/apache/arrow/pull/12685
Adding minor changes missed from: https://github.com/apache/arrow/pull/12671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] vibhatha commented on pull request #12685: [MINOR]: Minor comment fix
Posted by GitBox <gi...@apache.org>.
vibhatha commented on pull request #12685:
URL: https://github.com/apache/arrow/pull/12685#issuecomment-1074714632
cc @edponce @westonpace minor modification added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12685: MINOR: [C++] Minor comment fix
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12685:
URL: https://github.com/apache/arrow/pull/12685#issuecomment-1080916885
Benchmark runs are scheduled for baseline = 68164c8df941c97b8fabaa4d0fd417e1905895a7 and contender = 3eb5673597bf67246271b6c9a98e6f812d4e01a7. 3eb5673597bf67246271b6c9a98e6f812d4e01a7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/dad7c884cd334f2da9712dd5a122869b...545d323a996d444793d18283379176ed/)
[Finished :arrow_down:0.17% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/32be7f52132a4885a6f42adb11adea8d...b12320a2aacf47928ec7ce1424347f67/)
[Failed :arrow_down:3.57% :arrow_up:2.14%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f7c68b0e0bc84847a396dccdf7ffc304...5245005e4a5346c78955ac5295410972/)
[Finished :arrow_down:4.3% :arrow_up:15.06%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a7cea01cb1834f2cb5d8262c50ccf3e9...028bc87a866a4c40852037bfeff8ab50/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #12685: MINOR: [C++] Minor comment fix
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #12685:
URL: https://github.com/apache/arrow/pull/12685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12685: MINOR: [C++] Minor comment fix
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12685:
URL: https://github.com/apache/arrow/pull/12685#issuecomment-1080916885
Benchmark runs are scheduled for baseline = 68164c8df941c97b8fabaa4d0fd417e1905895a7 and contender = 3eb5673597bf67246271b6c9a98e6f812d4e01a7. 3eb5673597bf67246271b6c9a98e6f812d4e01a7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/dad7c884cd334f2da9712dd5a122869b...545d323a996d444793d18283379176ed/)
[Finished :arrow_down:0.17% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/32be7f52132a4885a6f42adb11adea8d...b12320a2aacf47928ec7ce1424347f67/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f7c68b0e0bc84847a396dccdf7ffc304...5245005e4a5346c78955ac5295410972/)
[Finished :arrow_down:4.3% :arrow_up:15.06%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a7cea01cb1834f2cb5d8262c50ccf3e9...028bc87a866a4c40852037bfeff8ab50/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12685: MINOR: [C++] Minor comment fix
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12685:
URL: https://github.com/apache/arrow/pull/12685#issuecomment-1080916885
Benchmark runs are scheduled for baseline = 68164c8df941c97b8fabaa4d0fd417e1905895a7 and contender = 3eb5673597bf67246271b6c9a98e6f812d4e01a7. 3eb5673597bf67246271b6c9a98e6f812d4e01a7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/dad7c884cd334f2da9712dd5a122869b...545d323a996d444793d18283379176ed/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/32be7f52132a4885a6f42adb11adea8d...b12320a2aacf47928ec7ce1424347f67/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f7c68b0e0bc84847a396dccdf7ffc304...5245005e4a5346c78955ac5295410972/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a7cea01cb1834f2cb5d8262c50ccf3e9...028bc87a866a4c40852037bfeff8ab50/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #12685: MINOR: [C++] Minor comment fix
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #12685:
URL: https://github.com/apache/arrow/pull/12685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12685: [MINOR]: Minor comment fix
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12685:
URL: https://github.com/apache/arrow/pull/12685#issuecomment-1074714238
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12685: MINOR: [C++] Minor comment fix
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12685:
URL: https://github.com/apache/arrow/pull/12685#issuecomment-1080916885
Benchmark runs are scheduled for baseline = 68164c8df941c97b8fabaa4d0fd417e1905895a7 and contender = 3eb5673597bf67246271b6c9a98e6f812d4e01a7. 3eb5673597bf67246271b6c9a98e6f812d4e01a7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/dad7c884cd334f2da9712dd5a122869b...545d323a996d444793d18283379176ed/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/32be7f52132a4885a6f42adb11adea8d...b12320a2aacf47928ec7ce1424347f67/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f7c68b0e0bc84847a396dccdf7ffc304...5245005e4a5346c78955ac5295410972/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/a7cea01cb1834f2cb5d8262c50ccf3e9...028bc87a866a4c40852037bfeff8ab50/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #12685: MINOR: [C++] Minor comment fix
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #12685:
URL: https://github.com/apache/arrow/pull/12685#issuecomment-1080663611
Reopening PR to trigger CI anew.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org