You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2018/02/28 16:43:33 UTC

[isis] branch master updated: ISIS-1841 cleanup maven dependencies

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git


The following commit(s) were added to refs/heads/master by this push:
     new de620bf  ISIS-1841 cleanup maven dependencies
de620bf is described below

commit de620bf226ffc54e7c735a4b23288e88e250f743
Author: Andi Huber <ah...@apache.org>
AuthorDate: Wed Feb 28 17:43:29 2018 +0100

    ISIS-1841 cleanup maven dependencies
    
    remove reflections dependencies
    remove guava from applib, it's still in applib-legacy
---
 core/applib-legacy/pom.xml | 25 ++-----------------------
 core/applib/pom.xml        | 19 +++++--------------
 core/pom.xml               |  4 ----
 3 files changed, 7 insertions(+), 41 deletions(-)

diff --git a/core/applib-legacy/pom.xml b/core/applib-legacy/pom.xml
index 8709d63..0daee1e 100644
--- a/core/applib-legacy/pom.xml
+++ b/core/applib-legacy/pom.xml
@@ -27,8 +27,8 @@
     </description>
 
 	<properties>
-		<jar-plugin.automaticModuleName>org.apache.isis.legacy-1</jar-plugin.automaticModuleName>
-		<git-plugin.propertiesDir>org/apache/isis/legacy-1</git-plugin.propertiesDir>
+		<jar-plugin.automaticModuleName>org.apache.isis.applib-legacy</jar-plugin.automaticModuleName>
+		<git-plugin.propertiesDir>org/apache/isis/applib-legacy</git-plugin.propertiesDir>
 	</properties>
 
 
@@ -63,33 +63,12 @@
 			<artifactId>isis-core-applib</artifactId>
 			<scope>compile</scope>
 		</dependency>
-		
 		<dependency>
 			<groupId>org.apache.isis.core</groupId>
 			<artifactId>isis-core-applib</artifactId>
 			<type>test-jar</type>
 			<scope>test</scope>
 		</dependency>
-		
-	    <!-- as used by internal API, 
-       	also provides com.google.code.findbugs/annotations @Nullable, 
-       	but not transitive -->
-        <dependency>
-            <groupId>org.reflections</groupId>
-            <artifactId>reflections</artifactId>
-            <!--
-            ideally we would like to make this optional (to enforce usage of internal
-             reflective API, with only applib is allowed to access reflections directly.
-              HOWEVER, there is also a runtime dependency on org.reflections.vfs.Vfs.UrlType. -->
-            <optional>false</optional>
-            <exclusions>
-            	<exclusion>
-            	    <!-- whatever reflections is dependent on, it should not be transitive  -->
-            		<groupId>com.google.guava</groupId>
-            		<artifactId>guava</artifactId>
-            	</exclusion>
-            </exclusions>
-        </dependency>
 
 	</dependencies>
 
diff --git a/core/applib/pom.xml b/core/applib/pom.xml
index 2d84f74..4d9c653 100644
--- a/core/applib/pom.xml
+++ b/core/applib/pom.xml
@@ -151,27 +151,18 @@
             <artifactId>isis-core-unittestsupport</artifactId>
             <scope>test</scope>
             <exclusions>
+            	<!-- whatever unittestsupport is dependent on, it should not be transitive  -->
             	<exclusion>
-            	    <!-- whatever unittestsupport is dependent on, it should not be transitive  -->
             		<groupId>org.reflections</groupId>
             		<artifactId>reflections</artifactId>
             	</exclusion>
+            	<exclusion>
+	            	<groupId>com.google.guava</groupId>
+					<artifactId>guava</artifactId>
+            	</exclusion>
             </exclusions>
         </dependency>
 
-        <!-- as used by internal API, 
-        	also provides com.google.code.findbugs/annotations @Nullable, 
-        	but not transitive -->
-        <dependency>
-            <groupId>org.reflections</groupId>
-            <artifactId>reflections</artifactId>
-            <!--
-            ideally we would like to make this optional (to enforce usage of internal
-             reflective API, with only applib is allowed to access reflections directly.
-              HOWEVER, there is also a runtime dependency on org.reflections.vfs.Vfs.UrlType. -->
-            <optional>false</optional>
-        </dependency>
-
 		<!-- provides @Nullable -->
         <dependency>
         	<groupId>com.google.code.findbugs</groupId>
diff --git a/core/pom.xml b/core/pom.xml
index 35344e8..ddc0d36 100644
--- a/core/pom.xml
+++ b/core/pom.xml
@@ -2131,10 +2131,6 @@ ${license.additional-notes}
     <dependencies>
         <!-- compile dependencies -->
         <dependency>
-            <groupId>com.google.guava</groupId>
-            <artifactId>guava</artifactId>
-        </dependency>
-        <dependency>
             <groupId>org.hamcrest</groupId>
             <artifactId>hamcrest-library</artifactId>
         </dependency>

-- 
To stop receiving notification emails like this one, please contact
ahuber@apache.org.