You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2017/06/09 16:11:18 UTC

[jira] [Commented] (HBASE-18201) add UT and docs for DataBlockEncodingTool

    [ https://issues.apache.org/jira/browse/HBASE-18201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16044605#comment-16044605 ] 

stack commented on HBASE-18201:
-------------------------------

I like the suggestion that we just remove it but I don't think we can. This is a neglected area of the code base -- encodings in general -- and in need of love. The first thing a surveyor will look for when they go digging in here is a tool like this.

Make this a noob issue? It is a nice, contained entry point. Could be good place for a prospective contributor who wants to get involved.

Thanks for reading our code [~chia7712]

> add UT and docs for DataBlockEncodingTool
> -----------------------------------------
>
>                 Key: HBASE-18201
>                 URL: https://issues.apache.org/jira/browse/HBASE-18201
>             Project: HBase
>          Issue Type: Task
>            Reporter: Chia-Ping Tsai
>            Priority: Minor
>
> There is no example, documents, or tests for DataBlockEncodingTool. We should have it friendly if any use case exists. Otherwise, we should just get rid of it because DataBlockEncodingTool presumes that the implementation of cell returned from DataBlockEncoder is KeyValue. The presume may obstruct the cleanup of KeyValue references in the code base of read/write path.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)