You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "yongjinhou (via GitHub)" <gi...@apache.org> on 2023/06/15 09:20:54 UTC
[GitHub] [doris] yongjinhou opened a new pull request, #20857: [Enhancement](tvf) Add frontends table-valued-function
yongjinhou opened a new pull request, #20857:
URL: https://github.com/apache/doris/pull/20857
## Proposed changes
Issue Number: close #20646
This pr implement a new Metadata TVF called frontends.
The use of frontends TVF like:
select * from frontends()\G;
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] luozenglin merged pull request #20857: [Enhancement](tvf) Add frontends table-valued-function
Posted by "luozenglin (via GitHub)" <gi...@apache.org>.
luozenglin merged PR #20857:
URL: https://github.com/apache/doris/pull/20857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yongjinhou commented on a diff in pull request #20857: [Enhancement](tvf) Add frontends table-valued-function
Posted by "yongjinhou (via GitHub)" <gi...@apache.org>.
yongjinhou commented on code in PR #20857:
URL: https://github.com/apache/doris/pull/20857#discussion_r1232009455
##########
gensrc/thrift/Types.thrift:
##########
@@ -687,6 +687,7 @@ enum TSortType {
enum TMetadataType {
ICEBERG,
BACKENDS,
+ FRONTENDS,
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20857: [Enhancement](tvf) Add frontends table-valued-function
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20857:
URL: https://github.com/apache/doris/pull/20857#issuecomment-1592759190
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yongjinhou commented on pull request #20857: [Enhancement](tvf) Add frontends table-valued-function
Posted by "yongjinhou (via GitHub)" <gi...@apache.org>.
yongjinhou commented on PR #20857:
URL: https://github.com/apache/doris/pull/20857#issuecomment-1593975057
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yongjinhou commented on pull request #20857: [Enhancement](tvf) Add frontends table-valued-function
Posted by "yongjinhou (via GitHub)" <gi...@apache.org>.
yongjinhou commented on PR #20857:
URL: https://github.com/apache/doris/pull/20857#issuecomment-1592686096
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yongjinhou commented on pull request #20857: [Enhancement](tvf) Add frontends table-valued-function
Posted by "yongjinhou (via GitHub)" <gi...@apache.org>.
yongjinhou commented on PR #20857:
URL: https://github.com/apache/doris/pull/20857#issuecomment-1594385865
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yongjinhou commented on pull request #20857: [Enhancement](tvf) Add frontends table-valued-function
Posted by "yongjinhou (via GitHub)" <gi...@apache.org>.
yongjinhou commented on PR #20857:
URL: https://github.com/apache/doris/pull/20857#issuecomment-1595926218
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20857: [Enhancement](tvf) Add frontends table-valued-function
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20857:
URL: https://github.com/apache/doris/pull/20857#issuecomment-1596386289
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yongjinhou commented on pull request #20857: [Enhancement](tvf) Add frontends table-valued-function
Posted by "yongjinhou (via GitHub)" <gi...@apache.org>.
yongjinhou commented on PR #20857:
URL: https://github.com/apache/doris/pull/20857#issuecomment-1594388203
> u need to implement this function for Nereids(new optimizer) too
I will do it latter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20857: [Enhancement](tvf) Add frontends table-valued-function
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20857:
URL: https://github.com/apache/doris/pull/20857#issuecomment-1594295735
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yongjinhou commented on pull request #20857: [Enhancement](tvf) Add frontends table-valued-function
Posted by "yongjinhou (via GitHub)" <gi...@apache.org>.
yongjinhou commented on PR #20857:
URL: https://github.com/apache/doris/pull/20857#issuecomment-1596045145
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20857: [Enhancement](tvf) Add frontends table-valued-function
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20857:
URL: https://github.com/apache/doris/pull/20857#issuecomment-1592694024
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20857: [Enhancement](tvf) Add frontends table-valued-function
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20857:
URL: https://github.com/apache/doris/pull/20857#issuecomment-1594411512
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yongjinhou commented on pull request #20857: [Enhancement](tvf) Add frontends table-valued-function
Posted by "yongjinhou (via GitHub)" <gi...@apache.org>.
yongjinhou commented on PR #20857:
URL: https://github.com/apache/doris/pull/20857#issuecomment-1592923290
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20857: [Enhancement](tvf) Add frontends table-valued-function
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20857:
URL: https://github.com/apache/doris/pull/20857#issuecomment-1592929807
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20857: [Enhancement](tvf) Add frontends table-valued-function
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20857:
URL: https://github.com/apache/doris/pull/20857#issuecomment-1596401806
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] luozenglin commented on a diff in pull request #20857: [Enhancement](tvf) Add frontends table-valued-function
Posted by "luozenglin (via GitHub)" <gi...@apache.org>.
luozenglin commented on code in PR #20857:
URL: https://github.com/apache/doris/pull/20857#discussion_r1231986042
##########
gensrc/thrift/Types.thrift:
##########
@@ -687,6 +687,7 @@ enum TSortType {
enum TMetadataType {
ICEBERG,
BACKENDS,
+ FRONTENDS,
Review Comment:
Never add enum definition in the middle of the existing thrift definition. https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240883637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yongjinhou commented on pull request #20857: [Enhancement](tvf) Add frontends table-valued-function
Posted by "yongjinhou (via GitHub)" <gi...@apache.org>.
yongjinhou commented on PR #20857:
URL: https://github.com/apache/doris/pull/20857#issuecomment-1594309483
run Need_2_Approval
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yongjinhou commented on pull request #20857: [Enhancement](tvf) Add frontends table-valued-function
Posted by "yongjinhou (via GitHub)" <gi...@apache.org>.
yongjinhou commented on PR #20857:
URL: https://github.com/apache/doris/pull/20857#issuecomment-1596382882
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20857: [Enhancement](tvf) Add frontends table-valued-function
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20857:
URL: https://github.com/apache/doris/pull/20857#issuecomment-1592759274
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org