You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "weizhouapache (via GitHub)" <gi...@apache.org> on 2024/01/10 10:02:32 UTC
[PR] UI: ignore error when list public ips for CKS clusters [cloudstack]
weizhouapache opened a new pull request, #8489:
URL: https://github.com/apache/cloudstack/pull/8489
### Description
This PR fixes #7681
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-1884620186
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8489?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`76aff0f`)](https://app.codecov.io/gh/apache/cloudstack/commit/76aff0f422a476f1de720999d309f8f07756cd50?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 13.12% compared to head [(`07b6de3`)](https://app.codecov.io/gh/apache/cloudstack/pull/8489?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 13.12%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 4.18 #8489 +/- ##
=========================================
Coverage 13.12% 13.12%
Complexity 9142 9142
=========================================
Files 2720 2720
Lines 257744 257744
Branches 40182 40182
=========================================
Hits 33839 33839
+ Misses 219615 219614 -1
- Partials 4290 4291 +1
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8489?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2067731703
<b>[SF] Trillian test result (tid-9935)</b>
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 71400 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8489-t9935-kvm-alma9.zip
Smoke tests completed. 56 look OK, 54 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_events_resource | `Error` | 3.22 | test_events_resource.py
test_DeleteDomain | `Failure` | 98.67 | test_accounts.py
test_forceDeleteDomain | `Failure` | 103.72 | test_accounts.py
test_dedicateGuestVlanRange | `Error` | 0.00 | test_guest_vlan_range.py
ContextSuite context=TestDedicateGuestVlanRange>:teardown | `Error` | 0.00 | test_guest_vlan_range.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 2.85 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 2.85 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Failure` | 3.78 | test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Failure` | 3.85 | test_internal_lb.py
test_01_create_ipv6_public_ip_range | `Error` | 0.04 | test_ipv6_infra.py
test_04_verify_guest_lspci | `Error` | 810.64 | test_deploy_virtio_scsi_vm.py
test_06_verify_guest_lspci_again | `Error` | 810.67 | test_deploy_virtio_scsi_vm.py
ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | test_loadbalance.py
test_01_ping_in_vr_success | `Failure` | 0.03 | test_diagnostics.py
test_02_ping_in_vr_failure | `Failure` | 0.03 | test_diagnostics.py
test_07_arping_in_vr | `Failure` | 0.02 | test_diagnostics.py
test_10_traceroute_in_vr | `Failure` | 0.02 | test_diagnostics.py
test_13_retrieve_vr_default_files | `Failure` | 0.02 | test_diagnostics.py
test_14_retrieve_vr_one_file | `Failure` | 0.02 | test_diagnostics.py
test_01_native_to_native_network_migration | `Error` | 4.94 | test_migration.py
test_02_native_to_native_vpc_migration | `Error` | 7.56 | test_migration.py
test_01_deploy_vm_from_direct_download_template_nfs_storage | `Error` | 4.55 | test_direct_download.py
ContextSuite context=TestDirectDownloadTemplates>:teardown | `Error` | 1.09 | test_direct_download.py
test_network_acl | `Error` | 2.39 | test_network_acl.py
test_03_create_network_domain_network_offering | `Error` | 8.26 | test_domain_network_offerings.py
ContextSuite context=TestIpv6Network>:setup | `Error` | 0.00 | test_network_ipv6.py
test_03_create_vpc_domain_vpc_offering | `Error` | 9.78 | test_domain_vpc_offerings.py
test_10_vpc_tier_kubernetes_cluster | `Error` | 2.57 | test_kubernetes_clusters.py
ContextSuite context=TestNetworkPermissions>:setup | `Error` | 0.00 | test_network_permissions.py
test_delete_account | `Error` | 108.75 | test_network.py
test_delete_network_while_vm_on_it | `Error` | 5.66 | test_network.py
test_delete_network_while_vm_on_it | `Error` | 5.66 | test_network.py
test_deploy_vm_l2network | `Error` | 6.68 | test_network.py
test_deploy_vm_l2network | `Error` | 6.68 | test_network.py
test_l2network_restart | `Error` | 7.76 | test_network.py
test_l2network_restart | `Error` | 7.76 | test_network.py
ContextSuite context=TestL2Networks>:teardown | `Error` | 8.90 | test_network.py
test_01_port_fwd_on_src_nat | `Failure` | 0.03 | test_network.py
test_02_port_fwd_on_non_src_nat | `Error` | 0.03 | test_network.py
ContextSuite context=TestPublicIP>:setup | `Error` | 7.71 | test_network.py
test_reboot_router | `Error` | 160.71 | test_network.py
test_releaseIP | `Error` | 41.27 | test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule | `Error` | 0.04 | test_network.py
test_network_rules_acquired_public_ip_2_nat_rule | `Error` | 0.04 | test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | `Error` | 0.04 | test_network.py
test_01_nic | `Error` | 44.52 | test_nic.py
test_extendPhysicalNetworkVlan | `Error` | 0.05 | test_non_contigiousvlan.py
ContextSuite context=TestNonStrictAffinityGroups>:setup | `Error` | 0.00 | test_nonstrict_affinity_group.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup | `Error` | 0.00 | test_password_server.py
test_01_isolated_persistent_network | `Error` | 0.05 | test_persistent_network.py
ContextSuite context=TestPortablePublicIPAcquire>:setup | `Error` | 0.00 | test_portable_publicip.py
test_01_create_delete_portforwarding_fornonvpc | `Error` | 3.37 | test_portforwardingrules.py
test_01_vpc_privategw_acl | `Failure` | 5.42 | test_privategw_acl.py
test_02_vpc_privategw_static_routes | `Failure` | 5.59 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 5.32 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 5.24 | test_privategw_acl.py
test_dedicatePublicIpRange | `Error` | 0.03 | test_public_ip_range.py
test_dedicate_public_ip_range_for_system_vms | `Error` | 0.03 | test_public_ip_range.py
test_dedicate_public_ip_range_for_system_vms_01_ssvm | `Error` | 0.11 | test_public_ip_range.py
test_dedicate_public_ip_range_for_system_vms_02_cpvm | `Error` | 0.12 | test_public_ip_range.py
test_create_pvlan_network | `Error` | 0.08 | test_pvlan.py
test_CRUD_operations_userdata | `Error` | 3.36 | test_register_userdata.py
test_deploy_vm_with_registered_userdata | `Error` | 3.51 | test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_allow | `Error` | 3.77 | test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_append | `Error` | 3.92 | test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_deny | `Error` | 3.60 | test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_params | `Error` | 3.41 | test_register_userdata.py
test_link_and_unlink_userdata_to_template | `Error` | 3.19 | test_register_userdata.py
test_user_userdata_crud | `Error` | 3.54 | test_register_userdata.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
test_01_sys_vm_start | `Failure` | 0.16 | test_secondary_storage.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.32 | test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:setup | `Error` | 0.00 | test_snapshots.py
test_01_list_sec_storage_vm | `Failure` | 0.05 | test_ssvm.py
test_02_list_cpvm_vm | `Failure` | 0.04 | test_ssvm.py
test_03_ssvm_internals | `Failure` | 0.04 | test_ssvm.py
test_04_cpvm_internals | `Failure` | 0.04 | test_ssvm.py
test_05_stop_ssvm | `Failure` | 0.04 | test_ssvm.py
test_06_stop_cpvm | `Failure` | 0.05 | test_ssvm.py
test_07_reboot_ssvm | `Failure` | 0.05 | test_ssvm.py
test_08_reboot_cpvm | `Failure` | 0.04 | test_ssvm.py
test_09_reboot_ssvm_forced | `Failure` | 0.04 | test_ssvm.py
test_10_reboot_cpvm_forced | `Failure` | 0.04 | test_ssvm.py
test_11_destroy_ssvm | `Failure` | 0.05 | test_ssvm.py
test_12_destroy_cpvm | `Failure` | 0.04 | test_ssvm.py
ContextSuite context=TestVMWareStoragePolicies>:setup | `Error` | 0.00 | test_storage_policy.py
test_02_create_template_with_checksum_sha1 | `Error` | 65.61 | test_templates.py
test_03_create_template_with_checksum_sha256 | `Error` | 65.56 | test_templates.py
test_04_create_template_with_checksum_md5 | `Error` | 65.60 | test_templates.py
test_05_create_template_with_no_checksum | `Error` | 65.62 | test_templates.py
test_02_deploy_vm_from_direct_download_template | `Error` | 1.33 | test_templates.py
ContextSuite context=TestCreateTemplateWithDirectDownload>:teardown | `Error` | 12.92 | test_templates.py
ContextSuite context=TestTemplates>:setup | `Error` | 20.01 | test_templates.py
ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestLBRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestNatRuleUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestPublicIPUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestSnapshotUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVmUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVolumeUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVpnUsage>:setup | `Error` | 0.00 | test_usage.py
ContextSuite context=TestVmAutoScaling>:setup | `Error` | 0.00 | test_vm_autoscaling.py
test_01_deploy_vm_on_specific_host | `Error` | 1.36 | test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster | `Error` | 1.35 | test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod | `Error` | 1.37 | test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 1.42 | test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod | `Error` | 1.35 | test_vm_deployment_planner.py
ContextSuite context=TestDeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
test_01_migrate_VM_and_root_volume | `Error` | 1.33 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 1.32 | test_vm_life_cycle.py
ContextSuite context=TestVMLifeCycle>:setup | `Error` | 4.17 | test_vm_life_cycle.py
ContextSuite context=TestVmSnapshot>:setup | `Error` | 3.85 | test_vm_snapshots.py
ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
test_01_root_volume_encryption | `Error` | 1.34 | test_volumes.py
test_02_data_volume_encryption | `Error` | 1.34 | test_volumes.py
test_03_root_and_data_volume_encryption | `Error` | 1.41 | test_volumes.py
ContextSuite context=TestVolumes>:setup | `Error` | 23.14 | test_volumes.py
ContextSuite context=TestIpv6Vpc>:setup | `Error` | 0.00 | test_vpc_ipv6.py
ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 1.62 | test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 1.72 | test_host_maintenance.py
test_01_cancel_host_maintenance_ssh_enabled_agent_connected | `Failure` | 12.59 | test_host_maintenance.py
test_03_cancel_host_maintenance_ssh_disabled_agent_connected | `Failure` | 18.75 | test_host_maintenance.py
test_04_cancel_host_maintenance_ssh_disabled_agent_disconnected | `Failure` | 26.40 | test_host_maintenance.py
ContextSuite context=TestHostMaintenanceAgents>:teardown | `Error` | 27.55 | test_host_maintenance.py
test_disable_oobm_ha_state_ineligible | `Error` | 1516.44 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2069121983
@weizhouapache , as admin user I can not register an iso :
not sure if this is related.
as a normal user I don't even get to the overview :
as shown in the image , the user doesn't even get the button to register the iso.
FYI, haven't investigated this yet:
```
2024-04-22 11:02:55,541 ERROR [c.c.a.ApiServer] (qtp239372207-16:ctx-cc15c2af ctx-2969dc60) (logid:3e39b3ff) unhandled exception executing api command: [Ljava.lang.String;@4eefc745
java.lang.NullPointerException
at com.cloud.kubernetes.version.KubernetesVersionManagerImpl.createKubernetesSupportedVersionResponse(KubernetesVersionManagerImpl.java:107)
at com.cloud.kubernetes.version.KubernetesVersionManagerImpl.createKubernetesSupportedVersionListResponse(KubernetesVersionManagerImpl.java:117)
at com.cloud.kubernetes.version.KubernetesVersionManagerImpl.listKubernetesSupportedVersions(KubernetesVersionManagerImpl.java:278)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:344)
at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:198)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
at org.springframework.aop.interceptor.ExposeInvocationInterceptor.invoke(ExposeInvocationInterceptor.java:97)
at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:215)
at com.sun.proxy.$Proxy439.listKubernetesSupportedVersions(Unknown Source)
at org.apache.cloudstack.api.command.user.kubernetes.version.ListKubernetesSupportedVersionsCmd.execute(ListKubernetesSupportedVersionsCmd.java:99)
at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:163)
at com.cloud.api.ApiServer.queueCommand(ApiServer.java:803)
at com.cloud.api.ApiServer.handleRequest(ApiServer.java:624)
at com.cloud.api.ApiServlet.processRequestInContext(ApiServlet.java:342)
at com.cloud.api.ApiServlet$1.run(ApiServlet.java:149)
at org.apache.cloudstack.managed.context.impl.DefaultManagedContext$1.call(DefaultManagedContext.java:55)
at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.callWithContext(DefaultManagedContext.java:102)
at org.apache.cloudstack.managed.context.impl.DefaultManagedContext.runWithContext(DefaultManagedContext.java:52)
at com.cloud.api.ApiServlet.processRequest(ApiServlet.java:146)
at com.cloud.api.ApiServlet.doGet(ApiServlet.java:100)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:645)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:750)
at org.eclipse.jetty.servlet.ServletHolder$NotAsync.service(ServletHolder.java:1450)
at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:799)
at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:554)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2063392666
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#discussion_r1447740138
##########
ui/src/views/compute/KubernetesServiceTab.vue:
##########
@@ -403,8 +403,8 @@ export default {
ips = ips.filter(x => x.issourcenat)
this.publicIpAddress = ips.length > 0 ? ips[0] : null
}
- }).catch(error => {
- this.$notifyError(error)
+ }).catch(() => {
+ this.publicIpAddress = null
Review Comment:
> Instead of ignoring the exception, why not check if the user has permission to use the API?
The issue is not caused by permission. The users have permission to the api, but they cannot list public ips of a shared network which has scope=domain
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-1940455838
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2072049226
@JoaoJandre @MejdiB can you test / review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#discussion_r1450410064
##########
ui/src/views/compute/KubernetesServiceTab.vue:
##########
@@ -403,8 +403,8 @@ export default {
ips = ips.filter(x => x.issourcenat)
this.publicIpAddress = ips.length > 0 ? ips[0] : null
}
- }).catch(error => {
- this.$notifyError(error)
+ }).catch(() => {
+ this.publicIpAddress = null
Review Comment:
> How do you know that @MejdiB is using shared networks with domain scope in their CKS clusters? Were you able to reproduce the error reported on #7681?
Yes, I am able to reproduce the issue in advanced zone with SG.
>
> In any case, shouldn't we test if the user is trying to list the public IPs of a shared network with domain scope and not call the API in this case? It's better than ignoring any error that might happen on the API call.
>
this PR is the simplest way.
The better solution might be (1) listNetworks; (2) skip if network type is Shared.
but it did not work in my testing ,may require some investigation.
> Also, a description of the tests done would be great.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2069198525
<b>[SF] Trillian Build Failed (tid-9955)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2072286148
> CLGTM, I don't have an env with security groups, I could deploy one but it might take me a while. It would be good if @MejdiB could validate this, otherwise, I can try to test it within a few weeks.
ok thnks, I'll merge as I have tested it. @MejdiB can always create a new issues if he has additional configurations/requirements
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2063390689
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2063832831
@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2071873177
> verified manually in a test env with security groups; a cluster can be seen without error messages.
cool, thanks @DaanHoogland
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2065613357
<b>[SF] Trillian test result (tid-9903)</b>
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 44286 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8489-t9903-kvm-alma9.zip
Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2063831518
@blueorangutan test alma9 kvm-alma9 keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2069046916
> Smoke tests completed. 56 look OK, 54 have errors, 0 did not run
note that this is a normal rate for security group zones :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2069563893
<b>[SF] Trillian Build Failed (tid-9956)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-1940456645
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-1969048553
@weizhouapache will this make it for 4.18.2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#discussion_r1447740138
##########
ui/src/views/compute/KubernetesServiceTab.vue:
##########
@@ -403,8 +403,8 @@ export default {
ips = ips.filter(x => x.issourcenat)
this.publicIpAddress = ips.length > 0 ? ips[0] : null
}
- }).catch(error => {
- this.$notifyError(error)
+ }).catch(() => {
+ this.publicIpAddress = null
Review Comment:
> Instead of ignoring the exception, why not check if the user has permission to use the API?
The issue is not caused by permission of API. The users have permission to the api, but they cannot list public ips of a shared network which has scope=domain
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-1940910809
thanks for review @DaanHoogland @JoaoJandre
moved this to draft. I will revisit later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#discussion_r1524340631
##########
ui/src/views/compute/KubernetesServiceTab.vue:
##########
@@ -403,8 +403,8 @@ export default {
ips = ips.filter(x => x.issourcenat)
this.publicIpAddress = ips.length > 0 ? ips[0] : null
}
- }).catch(error => {
- this.$notifyError(error)
+ }).catch(() => {
+ this.publicIpAddress = null
Review Comment:
test steps have been added
@JoaoJandre @DaanHoogland
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2063416169
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8489 (QA-JID-316)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2063427271
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2071863125
verified manually in a test env with security groups; a cluster can be seen without error messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-1893494553
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters [cloudstack]
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-1893493280
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2066709115
@blueorangutan test alma9 kvm-alma9 keepEnv securityGroups
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2063568256
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters [cloudstack]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2063333828
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8489?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 13.12%. Comparing base [(`76aff0f`)](https://app.codecov.io/gh/apache/cloudstack/commit/76aff0f422a476f1de720999d309f8f07756cd50?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`07b6de3`)](https://app.codecov.io/gh/apache/cloudstack/pull/8489?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 42 commits behind head on 4.18.
> :exclamation: Current head 07b6de3 differs from pull request most recent head 4b59441. Consider uploading reports for the commit 4b59441 to get more accurate results
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 4.18 #8489 +/- ##
=========================================
Coverage 13.12% 13.12%
Complexity 9142 9142
=========================================
Files 2720 2720
Lines 257744 257744
Branches 40182 40182
=========================================
Hits 33839 33839
+ Misses 219615 219614 -1
- Partials 4290 4291 +1
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/8489?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2071937866
@JoaoJandre are you ok with this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-1940465893
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8489 (QA-JID-278)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#discussion_r1487467214
##########
ui/src/views/compute/KubernetesServiceTab.vue:
##########
@@ -403,8 +403,8 @@ export default {
ips = ips.filter(x => x.issourcenat)
this.publicIpAddress = ips.length > 0 ? ips[0] : null
}
- }).catch(error => {
- this.$notifyError(error)
+ }).catch(() => {
+ this.publicIpAddress = null
Review Comment:
I too would like to see a test description.
I agree that preventing a call to the server is good, but a working solution is as well ;)
I could live with a comment in the code that explains the better solution and why it was not implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters [cloudstack]
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on code in PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#discussion_r1447735480
##########
ui/src/views/compute/KubernetesServiceTab.vue:
##########
@@ -403,8 +403,8 @@ export default {
ips = ips.filter(x => x.issourcenat)
this.publicIpAddress = ips.length > 0 ? ips[0] : null
}
- }).catch(error => {
- this.$notifyError(error)
+ }).catch(() => {
+ this.publicIpAddress = null
Review Comment:
Instead of ignoring the exception, why not check if the user has permission to use the API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters [cloudstack]
Posted by "JoaoJandre (via GitHub)" <gi...@apache.org>.
JoaoJandre commented on code in PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#discussion_r1450398683
##########
ui/src/views/compute/KubernetesServiceTab.vue:
##########
@@ -403,8 +403,8 @@ export default {
ips = ips.filter(x => x.issourcenat)
this.publicIpAddress = ips.length > 0 ? ips[0] : null
}
- }).catch(error => {
- this.$notifyError(error)
+ }).catch(() => {
+ this.publicIpAddress = null
Review Comment:
How do you know that @MejdiB is using shared networks with domain scope in their CKS clusters? Were you able to reproduce the error reported on #7681?
In any case, shouldn't we test if the user is trying to list the public IPs of a shared network with domain scope and not call the API in this case? It's better than ignoring any error that might happen on the API call.
Also, a description of the tests done would be great.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2063423388
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2071866768
reports in https://github.com/apache/cloudstack/pull/8489#issuecomment-2069121983 are serious but not related to this code (no proper error handling when no zone is ready and **enabled**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] UI: ignore error when list public ips for CKS clusters on Shared network [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#issuecomment-2066711425
@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org