[GitHub] [incubator-superset] mistercrunch commented on pull request #10128: fix: [search query view] edit link is broken

[GitBox <gi...@apache.org>]

mistercrunch commented on pull request #10128:
URL: https://github.com/apache/incubator-superset/pull/10128#issuecomment-648979706


   @willbarrett the reason why I removed the view is that I'm polluting the list view with the `data` attribute. We need `/query/api/read` to show data, but we don't want the CRUD list view to show the blob. 
   
   Normally we would create a derivative `ModelView` (as in `class QueryRestModelView(QueryModelView)`) and override the list_columns.
   
   I think it does make sense to kill the `QueryModelView` FAB CRUD as it is redundant to the query search view I'm fixing here, which is confusing.
   
   I'm hoping we can make a call on `QueryModelView` here in this PR and move forward.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org