You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2017/08/02 09:11:42 UTC
Re: Review Request 60440: Updated local development workflow of mesos
website.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60440/#review181952
-----------------------------------------------------------
Fix it, then Ship it!
While I see the value of being consistent with the CI bot's setup, I still strongly believe that we should remove this dev setup in favor of a simple `rake`-driven workflow (like we already discussed offline). I guess the most work there would be in updating the documentation.
Could you please either follow up with that cleanup now, or create a ticket?
site/README.md
Line 2 (original), 2 (patched)
<https://reviews.apache.org/r/60440/#comment257790>
`s/mesos/Mesos/`
site/README.md
Line 18 (original), 8 (patched)
<https://reviews.apache.org/r/60440/#comment257789>
`s/mesos/Mesos/`
site/README.md
Line 80 (original), 51 (patched)
<https://reviews.apache.org/r/60440/#comment257791>
`s/mesos/Mesos/`, also probably `s/repo/repository/`.
site/entrypoint.sh
Lines 24 (patched)
<https://reviews.apache.org/r/60440/#comment257784>
Do you still recall why this was needed? It would be great to add e.g., a JIRA or a small reproducer to eval in the future whether this is still needed.
site/mesos-website-dev.sh
Lines 25 (patched)
<https://reviews.apache.org/r/60440/#comment257785>
This should be quoted to deal with e.g., spaces, e.g.,
pushd "$MESOS_DIR"
site/mesos-website-dev.sh
Lines 27 (patched)
<https://reviews.apache.org/r/60440/#comment257787>
Let's decrease the risk of collisions here, e.g.,
TAGS=mesos/website:$(date +%s)-$RANDOM
This would be in line with what is done currently in support/docker-build.sh.
site/mesos-website-dev.sh
Lines 29 (patched)
<https://reviews.apache.org/r/60440/#comment257786>
Let's use single quotes here like in `support/mesos-website.sh`,
trap 'docker rmi $TAG' EXIT
site/mesos-website-dev.sh
Lines 38 (patched)
<https://reviews.apache.org/r/60440/#comment257788>
It is probably a good idea to adjust the mount options like already suggested in https://reviews.apache.org/r/60439/#comment257774. Also, let's quote this like in `support/mesos-website.sh`,
-v $MESOS_DIR":/mesos:Z
- Benjamin Bannier
On July 27, 2017, 2:30 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60440/
> -----------------------------------------------------------
>
> (Updated July 27, 2017, 2:30 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and haosdent huang.
>
>
> Bugs: MESOS-7625
> https://issues.apache.org/jira/browse/MESOS-7625
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made the layout and scripts consistent with CI based automatic
> publishing of the website.
>
>
> Diffs
> -----
>
> site/Dockerfile 230cfc779fe4f183d63cd99ef26dc540c68bff85
> site/README.md ebd3e6a0fea7ae0fe3b28719bcab28ee8f7c356c
> site/build.sh 06b1b32a5cdfaf2f9a69ce59339e0fd671e335de
> site/entrypoint.sh PRE-CREATION
> site/mesos-website-dev.sh PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/60440/diff/2/
>
>
> Testing
> -------
>
> Tested by running the script locally.
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 60440: Updated local development workflow of mesos
website.
Posted by Vinod Kone <vi...@gmail.com>.
> On Aug. 2, 2017, 9:11 a.m., Benjamin Bannier wrote:
> > While I see the value of being consistent with the CI bot's setup, I still strongly believe that we should remove this dev setup in favor of a simple `rake`-driven workflow (like we already discussed offline). I guess the most work there would be in updating the documentation.
> >
> > Could you please either follow up with that cleanup now, or create a ticket?
Filed MESOS-7860.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60440/#review181952
-----------------------------------------------------------
On July 27, 2017, 12:30 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60440/
> -----------------------------------------------------------
>
> (Updated July 27, 2017, 12:30 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, Benjamin Mahler, and haosdent huang.
>
>
> Bugs: MESOS-7625
> https://issues.apache.org/jira/browse/MESOS-7625
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Made the layout and scripts consistent with CI based automatic
> publishing of the website.
>
>
> Diffs
> -----
>
> site/Dockerfile 230cfc779fe4f183d63cd99ef26dc540c68bff85
> site/README.md ebd3e6a0fea7ae0fe3b28719bcab28ee8f7c356c
> site/build.sh 06b1b32a5cdfaf2f9a69ce59339e0fd671e335de
> site/entrypoint.sh PRE-CREATION
> site/mesos-website-dev.sh PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/60440/diff/2/
>
>
> Testing
> -------
>
> Tested by running the script locally.
>
>
> Thanks,
>
> Vinod Kone
>
>