[GitHub] [hive] mustafaiman commented on pull request #1733: HIVE-24346. Store HPL/SQL packages into HMS (amagyar)

[GitBox <gi...@apache.org>]

mustafaiman commented on pull request #1733:
URL: https://github.com/apache/hive/pull/1733#issuecomment-768454416


   @zeroflag 
   I see getAllStoredProcedures and dropPackage of RawStore are used in drop_database_core. These are internal to metastore. I was referring to getAllStoredProcedures and dropPackage of HiveMetastoreClient. Those metastore rpc's are not used by Hive at all. Are they there for some other client to use it? On a related note, how does a use drop a package?
   
   The problem with InMemoryPackageRegistry and `packages` hashmap is that once `packages` have the package we do not ever need to lookup InMemoryPackageRegistry again. At this point InMemoryPackageRegistry looks like a memory leak. Two structures keep the same info in different forms: source and compiled. The thing is we do not need source once we have the compiled one. So it leads me to think that InMemoryPackageRegistry is just a compilation of utility methods to compile the source but it also keeps the source forever unnecessarily.
   
   Also there are no new tests in this patch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org