You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/04/04 10:30:00 UTC
[jira] [Work logged] (HIVE-27145) Use StrictMath for remaining Math functions as followup of HIVE-23133
[ https://issues.apache.org/jira/browse/HIVE-27145?focusedWorklogId=854749&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-854749 ]
ASF GitHub Bot logged work on HIVE-27145:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/23 10:29
Start Date: 04/Apr/23 10:29
Worklog Time Spent: 10m
Work Description: TuroczyX commented on PR #4122:
URL: https://github.com/apache/hive/pull/4122#issuecomment-1495724690
Imho the precision is more important in big data world then performance. Maybe I think wrongly, but let's imagine a dataset with full of decimals where I as a customer would like to process a cos or degrees calculation on a TB scale. I would rather spend more CPU times on get precise value then to have just a good enough value. I would sacrifice the performance here.
Issue Time Tracking
-------------------
Worklog Id: (was: 854749)
Time Spent: 50m (was: 40m)
> Use StrictMath for remaining Math functions as followup of HIVE-23133
> ---------------------------------------------------------------------
>
> Key: HIVE-27145
> URL: https://issues.apache.org/jira/browse/HIVE-27145
> Project: Hive
> Issue Type: Task
> Components: UDF
> Reporter: Himanshu Mishra
> Assignee: Himanshu Mishra
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> [HIVE-23133|https://issues.apache.org/jira/browse/HIVE-23133] started using {{StrictMath}} for {{cos, exp, log}} UDFs to fix QTests failing as results vary based on hardware when using Math library.
> Follow it up by using {{StrictMath}} for other Math functions that can have same impact of underlying hardware namely, {{sin, tan, asin, acos, atan, sqrt, pow, cbrt}}.
> [JDK-4477961|https://bugs.openjdk.org/browse/JDK-4477961] (in Java 9) changed radians and degrees calculation leading to Q Test failures when tests are run on Java 9+, fix such tests.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)