You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by el...@apache.org on 2014/10/21 01:06:32 UTC

[15/50] git commit: FC-138 - Remove public default constructors from DAOs

FC-138 - Remove public default constructors from DAOs


Project: http://git-wip-us.apache.org/repos/asf/directory-fortress-core/repo
Commit: http://git-wip-us.apache.org/repos/asf/directory-fortress-core/commit/7f33959a
Tree: http://git-wip-us.apache.org/repos/asf/directory-fortress-core/tree/7f33959a
Diff: http://git-wip-us.apache.org/repos/asf/directory-fortress-core/diff/7f33959a

Branch: refs/heads/master
Commit: 7f33959a88c52bc615ed9f9c9d63c00cc3f1ce62
Parents: 01ef807
Author: Shawn McKinney <sh...@jts.us>
Authored: Sun Jun 29 13:01:47 2014 -0500
Committer: Shawn McKinney <sh...@jts.us>
Committed: Sun Jun 29 13:01:47 2014 -0500

----------------------------------------------------------------------
 .../rbac/dao/apache/AcceleratorDAO.java         | 72 ++++++++++++++++----
 .../fortress/rbac/dao/apache/AdminRoleDAO.java  |  5 --
 .../fortress/rbac/dao/apache/AuditDAO.java      |  8 ---
 .../fortress/rbac/dao/apache/OrgUnitDAO.java    |  8 ---
 .../fortress/rbac/dao/apache/PermDAO.java       |  8 ---
 .../fortress/rbac/dao/apache/PolicyDAO.java     |  8 ---
 .../fortress/rbac/dao/apache/RoleDAO.java       |  8 ---
 .../fortress/rbac/dao/apache/SdDAO.java         |  8 ---
 .../fortress/rbac/dao/apache/UserDAO.java       |  8 ---
 .../rbac/dao/unboundid/AdminRoleDAO.java        |  5 --
 .../fortress/rbac/dao/unboundid/AuditDAO.java   |  8 ---
 .../fortress/rbac/dao/unboundid/OrgUnitDAO.java |  8 ---
 .../fortress/rbac/dao/unboundid/PermDAO.java    |  8 ---
 .../fortress/rbac/dao/unboundid/PolicyDAO.java  |  8 ---
 .../fortress/rbac/dao/unboundid/RoleDAO.java    |  8 ---
 .../fortress/rbac/dao/unboundid/SdDAO.java      |  8 ---
 .../fortress/rbac/dao/unboundid/UserDAO.java    |  8 ---
 17 files changed, 60 insertions(+), 134 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/7f33959a/src/main/java/org/openldap/fortress/rbac/dao/apache/AcceleratorDAO.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/openldap/fortress/rbac/dao/apache/AcceleratorDAO.java b/src/main/java/org/openldap/fortress/rbac/dao/apache/AcceleratorDAO.java
index 9a0346d..187ed1e 100644
--- a/src/main/java/org/openldap/fortress/rbac/dao/apache/AcceleratorDAO.java
+++ b/src/main/java/org/openldap/fortress/rbac/dao/apache/AcceleratorDAO.java
@@ -52,23 +52,33 @@ import java.util.ArrayList;
 import java.util.List;
 
 
+/**
+ * Data access class for invoking RBAC Accelerator server-side operations.  This class utilizes the openldap accelerator component for LDAPv3 extended operations.
+ * This class follows the pattern of {@link org.openldap.fortress.AccessMgr} except policy decisions are session state are made/stored on server-side and not client-side.
+ * Its methods are not intended to be invoked by outside clients that should instead use {@link org.openldap.fortress.rbac.AccelMgrImpl}.
+ *
+ * This class is thread safe.
+ *
+ * @author Shawn McKinney
+ */
 public final class AcceleratorDAO extends ApacheDsDataProvider implements org.openldap.fortress.rbac.dao.AcceleratorDAO
 
 {
     private static final Logger LOG = LoggerFactory.getLogger( AcceleratorDAO.class.getName() );
-    /**
-     * Package private constructor
-     */
-    public AcceleratorDAO()
-    {
-    }
-
 
     /**
+     * Authenticate user and return sessionId inside {@link Session#sessionId}.
+     * This function follows the pattern from: {@link AccessMgr#createSession(org.openldap.fortress.rbac.User, boolean)}
+     * Success will result in rbac session state, i.e. {@link org.openldap.fortress.rbac.Session}, to be stored on server-side.
+     * Result may be stored inside RBAC server-side audit record and retrieved with {@link org.openldap.fortress.AuditMgr#searchBinds(org.openldap.fortress.rbac.UserAudit)}
+     * It uses the {@link RbacCreateSessionRequest} and {@link RbacCreateSessionResponse} accelerator APIs.
+     *
+     * todo: this method does not yet, but will soon, return password policy decisions.
+     *
      * @param user
-     * @return
+     * @return session contains a valid sessionId captured from accelerator createSession method.
      *
-     * @throws org.openldap.fortress.SecurityException
+     * @throws SecurityException rethrows {@code LdapException} with {@code GlobalErrIds.ACEL_CREATE_SESSION_ERR}.
      *
      */
     @Override
@@ -131,11 +141,12 @@ public final class AcceleratorDAO extends ApacheDsDataProvider implements org.op
      * to perform the operation on that object if and only if that permission is assigned to (at least)
      * one of the session's active roles. This implementation will verify the roles or userId correspond
      * to the subject's active roles are registered in the object's access control list.
+     * It uses the {@link RbacCheckAccessRequest} and {@link RbacCheckAccessResponse} accelerator APIs.
      *
      * @param session This object must be instantiated by calling {@link #createSession} method before passing into the method.  No variables need to be set by client after returned from createSession.
      * @param perm  must contain the object, {@link org.openldap.fortress.rbac.Permission#objName}, and operation, {@link org.openldap.fortress.rbac.Permission#opName}, of permission User is trying to access.
      * @return True if user has access, false otherwise.
-     * @throws SecurityException in the event of data validation failure, security policy violation or DAO error.
+     * @throws SecurityException rethrows {@code LdapException} with {@code GlobalErrIds.ACEL_CHECK_ACCESS_ERR}.
      */
     @Override
     public boolean checkAccess( Session session, Permission perm )
@@ -178,6 +189,16 @@ public final class AcceleratorDAO extends ApacheDsDataProvider implements org.op
     }
 
 
+    /**
+     * Deactivate user role from rbac session
+     * This function follows the pattern from: {@link AccessMgr#dropActiveRole(org.openldap.fortress.rbac.Session, org.openldap.fortress.rbac.UserRole)}.
+     * Success will result in rbac session state to be modified inside server-side cache.
+     * It uses the {@link RbacDropRoleRequest} and {@link RbacDropRoleResponse} accelerator APIs.
+     *
+     * @param session contains a valid sessionId captured from accelerator createSession method.
+     * @param userRole both the {@link UserRole#userId} and {@link UserRole#name} fields must be set before invoking.
+     * @throws SecurityException rethrows {@code LdapException} with {@code GlobalErrIds.ACEL_DROP_ROLE_ERR}.
+     */
     public void dropActiveRole( Session session, UserRole userRole ) throws SecurityException
     {
         LdapConnection ld = null;
@@ -211,6 +232,16 @@ public final class AcceleratorDAO extends ApacheDsDataProvider implements org.op
         }
     }
 
+    /**
+     * Activate user role into rbac session
+     * This function follows the pattern from: {@link AccessMgr#addActiveRole(org.openldap.fortress.rbac.Session, org.openldap.fortress.rbac.UserRole)}.
+     * Success will result in rbac session state to be modified inside server-side cache.
+     * It uses the {@link RbacAddRoleRequest} and {@link RbacAddRoleResponse} accelerator APIs.
+     *
+     * @param session contains a valid sessionId captured from accelerator createSession method.
+     * @param userRole both the {@link UserRole#userId} and {@link UserRole#name} fields must be set before invoking.
+     * @throws SecurityException rethrows {@code LdapException} with {@code GlobalErrIds.ACEL_ADD_ROLE_ERR}.
+     */
     public void addActiveRole( Session session, UserRole userRole ) throws SecurityException
     {
         LdapConnection ld = null;
@@ -256,6 +287,13 @@ public final class AcceleratorDAO extends ApacheDsDataProvider implements org.op
         }
     }
 
+    /**
+     * Delete the stored session on rbac accelerator server.
+     * It uses the {@link RbacDeleteSessionRequest} and {@link RbacDeleteSessionResponse} accelerator APIs.
+     *
+     * @param session contains a valid sessionId captured from accelerator createSession method.
+     * @throws SecurityException rethrows {@code LdapException} with {@code GlobalErrIds.ACEL_DELETE_SESSION_ERR}.
+     */
     public void deleteSession( Session session ) throws SecurityException
     {
         LdapConnection ld = null;
@@ -283,6 +321,16 @@ public final class AcceleratorDAO extends ApacheDsDataProvider implements org.op
     }
 
 
+    /**
+     * SessionRoles returns a list of UserRole's activated for user on rbac server.
+     * It uses the {@link RbacSessionRolesRequest} and {@link RbacSessionRolesResponse} accelerator APIs.
+     *
+     * todo: This method does not yet, but will soon populate temporal constraints associated with entities returned.
+     *
+     * @param session contains a valid sessionId captured from accelerator createSession method.
+     * @return List of type UserRole.  May be null if user has no roles activated in session stored - server side.
+     * @throws SecurityException rethrows {@code LdapException} with {@code GlobalErrIds.ACEL_SESSION_ROLES_ERR}.
+     */
     public List<UserRole> sessionRoles( Session session ) throws SecurityException
     {
         LdapConnection ld = null;
@@ -302,8 +350,8 @@ public final class AcceleratorDAO extends ApacheDsDataProvider implements org.op
                 userRoleList = new ArrayList<>(  );
                 for( String roleNm : sessionRolesResponse.getRoles() )
                 {
-                    UserRole userRole = new UserRole( session.getUserId(), roleNm );
-                    userRoleList.add( userRole );
+                    userRoleList.add( new UserRole( session.getUserId(), roleNm ) );
+                    // todo: add temporal constraints here
                 }
             }
         }

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/7f33959a/src/main/java/org/openldap/fortress/rbac/dao/apache/AdminRoleDAO.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/openldap/fortress/rbac/dao/apache/AdminRoleDAO.java b/src/main/java/org/openldap/fortress/rbac/dao/apache/AdminRoleDAO.java
index b8d1408..b10424d 100755
--- a/src/main/java/org/openldap/fortress/rbac/dao/apache/AdminRoleDAO.java
+++ b/src/main/java/org/openldap/fortress/rbac/dao/apache/AdminRoleDAO.java
@@ -139,11 +139,6 @@ public final class AdminRoleDAO extends ApacheDsDataProvider implements org.open
     };
 
 
-    public AdminRoleDAO()
-    {
-    }
-
-
     /**
      * Create a new AdminRole entity using supplied data.  Required attribute is {@link AdminRole#name}.
      * This data will be stored in the {@link GlobalIds#ADMIN_ROLE_ROOT} container.

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/7f33959a/src/main/java/org/openldap/fortress/rbac/dao/apache/AuditDAO.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/openldap/fortress/rbac/dao/apache/AuditDAO.java b/src/main/java/org/openldap/fortress/rbac/dao/apache/AuditDAO.java
index f128bbf..86a8d4d 100755
--- a/src/main/java/org/openldap/fortress/rbac/dao/apache/AuditDAO.java
+++ b/src/main/java/org/openldap/fortress/rbac/dao/apache/AuditDAO.java
@@ -180,14 +180,6 @@ public final class AuditDAO extends ApacheDsDataProvider implements org.openldap
 
 
     /**
-     * Package private default constructor.
-     */
-    public AuditDAO()
-    {
-    }
-
-
-    /**
      * This method returns failed authentications where the userid is not present in the directory.  This
      * is possible because Fortress performs read on user before the bind.
      * User:

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/7f33959a/src/main/java/org/openldap/fortress/rbac/dao/apache/OrgUnitDAO.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/openldap/fortress/rbac/dao/apache/OrgUnitDAO.java b/src/main/java/org/openldap/fortress/rbac/dao/apache/OrgUnitDAO.java
index a54e1e4..503adfd 100755
--- a/src/main/java/org/openldap/fortress/rbac/dao/apache/OrgUnitDAO.java
+++ b/src/main/java/org/openldap/fortress/rbac/dao/apache/OrgUnitDAO.java
@@ -120,14 +120,6 @@ public final class OrgUnitDAO extends ApacheDsDataProvider implements org.openld
 
 
     /**
-     * Package private default constructor.
-     */
-    public OrgUnitDAO()
-    {
-    }
-
-
-    /**
      * @param entity
      * @return
      * @throws org.openldap.fortress.CreateException

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/7f33959a/src/main/java/org/openldap/fortress/rbac/dao/apache/PermDAO.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/openldap/fortress/rbac/dao/apache/PermDAO.java b/src/main/java/org/openldap/fortress/rbac/dao/apache/PermDAO.java
index 09938b6..3fa6704 100755
--- a/src/main/java/org/openldap/fortress/rbac/dao/apache/PermDAO.java
+++ b/src/main/java/org/openldap/fortress/rbac/dao/apache/PermDAO.java
@@ -195,14 +195,6 @@ public final class PermDAO extends ApacheDsDataProvider implements org.openldap.
 
 
     /**
-     * Default constructor is used by internal Fortress classes.
-     */
-    public PermDAO()
-    {
-    }
-
-
-    /**
      * @param entity
      * @return
      * @throws org.openldap.fortress.CreateException

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/7f33959a/src/main/java/org/openldap/fortress/rbac/dao/apache/PolicyDAO.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/openldap/fortress/rbac/dao/apache/PolicyDAO.java b/src/main/java/org/openldap/fortress/rbac/dao/apache/PolicyDAO.java
index 5da81f9..1ebfbd9 100755
--- a/src/main/java/org/openldap/fortress/rbac/dao/apache/PolicyDAO.java
+++ b/src/main/java/org/openldap/fortress/rbac/dao/apache/PolicyDAO.java
@@ -138,14 +138,6 @@ public final class PolicyDAO extends ApacheDsDataProvider implements org.openlda
 
 
     /**
-     * Package private default constructor.
-     */
-    public PolicyDAO()
-    {
-    }
-
-
-    /**
      * @param entity
      * @return
      * @throws org.openldap.fortress.CreateException

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/7f33959a/src/main/java/org/openldap/fortress/rbac/dao/apache/RoleDAO.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/openldap/fortress/rbac/dao/apache/RoleDAO.java b/src/main/java/org/openldap/fortress/rbac/dao/apache/RoleDAO.java
index a68b53f..7463a93 100755
--- a/src/main/java/org/openldap/fortress/rbac/dao/apache/RoleDAO.java
+++ b/src/main/java/org/openldap/fortress/rbac/dao/apache/RoleDAO.java
@@ -114,14 +114,6 @@ public final class RoleDAO extends ApacheDsDataProvider implements org.openldap.
 
 
     /**
-     * Don't let any classes outside of this package construct instance of this class.
-     */
-    public RoleDAO()
-    {
-    }
-
-
-    /**
      * @param entity
      * @return
      * @throws CreateException

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/7f33959a/src/main/java/org/openldap/fortress/rbac/dao/apache/SdDAO.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/openldap/fortress/rbac/dao/apache/SdDAO.java b/src/main/java/org/openldap/fortress/rbac/dao/apache/SdDAO.java
index 811ed30..93ceff1 100755
--- a/src/main/java/org/openldap/fortress/rbac/dao/apache/SdDAO.java
+++ b/src/main/java/org/openldap/fortress/rbac/dao/apache/SdDAO.java
@@ -136,14 +136,6 @@ public final class SdDAO extends ApacheDsDataProvider implements org.openldap.fo
 
 
     /**
-     * Package private constructor
-     */
-    public SdDAO()
-    {
-    }
-
-
-    /**
      * @param entity
      * @return
      * @throws org.openldap.fortress.CreateException

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/7f33959a/src/main/java/org/openldap/fortress/rbac/dao/apache/UserDAO.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/openldap/fortress/rbac/dao/apache/UserDAO.java b/src/main/java/org/openldap/fortress/rbac/dao/apache/UserDAO.java
index eb1121c..bc892fa 100755
--- a/src/main/java/org/openldap/fortress/rbac/dao/apache/UserDAO.java
+++ b/src/main/java/org/openldap/fortress/rbac/dao/apache/UserDAO.java
@@ -327,14 +327,6 @@ public final class UserDAO extends ApacheDsDataProvider implements org.openldap.
 
 
     /**
-     * Don't let classes outside of this package construct this.
-     */
-    public UserDAO()
-    {
-    }
-
-
-    /**
      * @param entity
      * @return
      * @throws CreateException

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/7f33959a/src/main/java/org/openldap/fortress/rbac/dao/unboundid/AdminRoleDAO.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/openldap/fortress/rbac/dao/unboundid/AdminRoleDAO.java b/src/main/java/org/openldap/fortress/rbac/dao/unboundid/AdminRoleDAO.java
index 98ed2cc..9139f67 100755
--- a/src/main/java/org/openldap/fortress/rbac/dao/unboundid/AdminRoleDAO.java
+++ b/src/main/java/org/openldap/fortress/rbac/dao/unboundid/AdminRoleDAO.java
@@ -135,11 +135,6 @@ public final class AdminRoleDAO extends UnboundIdDataProvider implements org.ope
     };
 
 
-    public AdminRoleDAO()
-    {
-    }
-
-
     /**
      * Create a new AdminRole entity using supplied data.  Required attribute is {@link AdminRole#name}.
      * This data will be stored in the {@link GlobalIds#ADMIN_ROLE_ROOT} container.

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/7f33959a/src/main/java/org/openldap/fortress/rbac/dao/unboundid/AuditDAO.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/openldap/fortress/rbac/dao/unboundid/AuditDAO.java b/src/main/java/org/openldap/fortress/rbac/dao/unboundid/AuditDAO.java
index 63a2fd7..2d3d4be 100755
--- a/src/main/java/org/openldap/fortress/rbac/dao/unboundid/AuditDAO.java
+++ b/src/main/java/org/openldap/fortress/rbac/dao/unboundid/AuditDAO.java
@@ -177,14 +177,6 @@ public final class AuditDAO extends UnboundIdDataProvider implements org.openlda
 
 
     /**
-     * Package private default constructor.
-     */
-    public AuditDAO()
-    {
-    }
-
-
-    /**
      * This method returns failed authentications where the userid is not present in the directory.  This
      * is possible because Fortress performs read on user before the bind.
      * User:

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/7f33959a/src/main/java/org/openldap/fortress/rbac/dao/unboundid/OrgUnitDAO.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/openldap/fortress/rbac/dao/unboundid/OrgUnitDAO.java b/src/main/java/org/openldap/fortress/rbac/dao/unboundid/OrgUnitDAO.java
index 0d67967..b7d4836 100755
--- a/src/main/java/org/openldap/fortress/rbac/dao/unboundid/OrgUnitDAO.java
+++ b/src/main/java/org/openldap/fortress/rbac/dao/unboundid/OrgUnitDAO.java
@@ -117,14 +117,6 @@ public final class OrgUnitDAO extends UnboundIdDataProvider implements org.openl
 
 
     /**
-     * Package private default constructor.
-     */
-    public OrgUnitDAO()
-    {
-    }
-
-
-    /**
      * @param entity
      * @return
      * @throws org.openldap.fortress.CreateException

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/7f33959a/src/main/java/org/openldap/fortress/rbac/dao/unboundid/PermDAO.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/openldap/fortress/rbac/dao/unboundid/PermDAO.java b/src/main/java/org/openldap/fortress/rbac/dao/unboundid/PermDAO.java
index e1f8aff..10f47a5 100755
--- a/src/main/java/org/openldap/fortress/rbac/dao/unboundid/PermDAO.java
+++ b/src/main/java/org/openldap/fortress/rbac/dao/unboundid/PermDAO.java
@@ -188,14 +188,6 @@ public final class PermDAO extends UnboundIdDataProvider implements org.openldap
 
 
     /**
-     * Default constructor is used by internal Fortress classes.
-     */
-    public PermDAO()
-    {
-    }
-
-
-    /**
      * @param entity
      * @return
      * @throws org.openldap.fortress.CreateException

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/7f33959a/src/main/java/org/openldap/fortress/rbac/dao/unboundid/PolicyDAO.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/openldap/fortress/rbac/dao/unboundid/PolicyDAO.java b/src/main/java/org/openldap/fortress/rbac/dao/unboundid/PolicyDAO.java
index 81afca8..9f2ad80 100755
--- a/src/main/java/org/openldap/fortress/rbac/dao/unboundid/PolicyDAO.java
+++ b/src/main/java/org/openldap/fortress/rbac/dao/unboundid/PolicyDAO.java
@@ -134,14 +134,6 @@ public final class PolicyDAO extends UnboundIdDataProvider implements org.openld
 
 
     /**
-     * Package private default constructor.
-     */
-    public PolicyDAO()
-    {
-    }
-
-
-    /**
      * @param entity
      * @return
      * @throws org.openldap.fortress.CreateException

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/7f33959a/src/main/java/org/openldap/fortress/rbac/dao/unboundid/RoleDAO.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/openldap/fortress/rbac/dao/unboundid/RoleDAO.java b/src/main/java/org/openldap/fortress/rbac/dao/unboundid/RoleDAO.java
index 411e5cc..91affb6 100755
--- a/src/main/java/org/openldap/fortress/rbac/dao/unboundid/RoleDAO.java
+++ b/src/main/java/org/openldap/fortress/rbac/dao/unboundid/RoleDAO.java
@@ -109,14 +109,6 @@ public final class RoleDAO extends UnboundIdDataProvider implements org.openldap
 
 
     /**
-     * Don't let any classes outside of this package construct instance of this class.
-     */
-    public RoleDAO()
-    {
-    }
-
-
-    /**
      * @param entity
      * @return
      * @throws CreateException

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/7f33959a/src/main/java/org/openldap/fortress/rbac/dao/unboundid/SdDAO.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/openldap/fortress/rbac/dao/unboundid/SdDAO.java b/src/main/java/org/openldap/fortress/rbac/dao/unboundid/SdDAO.java
index e9a1788..c1cf0bf 100755
--- a/src/main/java/org/openldap/fortress/rbac/dao/unboundid/SdDAO.java
+++ b/src/main/java/org/openldap/fortress/rbac/dao/unboundid/SdDAO.java
@@ -133,14 +133,6 @@ public final class SdDAO extends UnboundIdDataProvider implements org.openldap.f
 
 
     /**
-     * Package private constructor
-     */
-    public SdDAO()
-    {
-    }
-
-
-    /**
      * @param entity
      * @return
      * @throws org.openldap.fortress.CreateException

http://git-wip-us.apache.org/repos/asf/directory-fortress-core/blob/7f33959a/src/main/java/org/openldap/fortress/rbac/dao/unboundid/UserDAO.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/openldap/fortress/rbac/dao/unboundid/UserDAO.java b/src/main/java/org/openldap/fortress/rbac/dao/unboundid/UserDAO.java
index 6edadfc..7c114ff 100755
--- a/src/main/java/org/openldap/fortress/rbac/dao/unboundid/UserDAO.java
+++ b/src/main/java/org/openldap/fortress/rbac/dao/unboundid/UserDAO.java
@@ -319,14 +319,6 @@ public final class UserDAO extends UnboundIdDataProvider implements org.openldap
 
 
     /**
-     * Don't let classes outside of this package construct this.
-     */
-    public UserDAO()
-    {
-    }
-
-
-    /**
      * @param entity
      * @return
      * @throws CreateException