You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by Tim Williams <wi...@gmail.com> on 2008/09/29 14:46:38 UTC
Re: svn commit: r700103 - /forrest/trunk/whiteboard/dispatcher/java/org/apache/forrest/dispatcher/impl/helper/AXIOMXPathPatched.java
> + HashMap<String, String> map = new HashMap<String, String>();
> + private String cleanFromExpressions(String pathPart, HashMap<String, String> map) {
Hey Thorsten, these caught my eye. Why not use interfaces in these places?
e.g.
Map<String, String> map = new HashMap<String, String>();
Nit-picky, for sure:)
--tim
Re: svn commit: r700103 -
/forrest/trunk/whiteboard/dispatcher/java/org/apache/forrest/dispatcher/impl/helper/AXIOMXPathPatched.java
Posted by Thorsten Scherler <th...@juntadeandalucia.es>.
On Mon, 2008-09-29 at 08:46 -0400, Tim Williams wrote:
> > + HashMap<String, String> map = new HashMap<String, String>();
>
> > + private String cleanFromExpressions(String pathPart, HashMap<String, String> map) {
>
> Hey Thorsten, these caught my eye. Why not use interfaces in these places?
>
> e.g.
> Map<String, String> map = new HashMap<String, String>();
>
> Nit-picky, for sure:)
I added your suggestion.
Cheers.
salu2
> --tim
--
Thorsten Scherler thorsten.at.apache.org
Open Source Java consulting, training and solutions