You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org> on 2016/07/01 07:14:11 UTC
[jira] [Commented] (SOLR-9262) Connection and read timeouts are
being ignored by UpdateShardHandler
[ https://issues.apache.org/jira/browse/SOLR-9262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15358536#comment-15358536 ]
Shalin Shekhar Mangar commented on SOLR-9262:
---------------------------------------------
bq. Our new retry policy should be universal. I did just look, and it seems it's not on by default, so i do think we want to fix that.
I am not sure I follow. If you mean the SolrHttpRequestRetryHandler then it is on by default unless someone disables it. The HttpClientUtil has the following in the setupBuilder method:
{code}
if (config.getBool(HttpClientUtil.PROP_USE_RETRY, true)) {
retBuilder = retBuilder.setRetryHandler(new SolrHttpRequestRetryHandler(3));
} else {
retBuilder = retBuilder.setRetryHandler(NO_RETRY);
}
{code}
In any case, I'll remove the explicit enabling of retry in UpdateShardHandler and commit the patch. Please open an issue if you think there is still a problem.
> Connection and read timeouts are being ignored by UpdateShardHandler
> --------------------------------------------------------------------
>
> Key: SOLR-9262
> URL: https://issues.apache.org/jira/browse/SOLR-9262
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
> Affects Versions: master (7.0)
> Reporter: Shalin Shekhar Mangar
> Assignee: Shalin Shekhar Mangar
> Fix For: master (7.0)
>
> Attachments: SOLR-9262.patch
>
>
> SOLR-4509 removed the usage of distribUpdateSoTimeout and distribUpdateConnTimeout from UpdateShardHandler causing the http client to be created with its default values of connection and read timeout.
> https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;a=blobdiff;f=solr/core/src/java/org/apache/solr/update/UpdateShardHandler.java;h=4fe869c25c9ea0588903d8d366e8d3533835b601;hp=a44b8f87b766d4f998d534156ceb83f4d42eadbb;hb=ce172ac;hpb=3f217aba6d4422d829be5ad77b02068c130dc7d3
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org