[GitHub] [arrow-adbc] lidavidm commented on a diff in pull request #681: feat(format): introduce AdbcDriver110

["lidavidm (via GitHub)" <gi...@apache.org>]

lidavidm commented on code in PR #681:
URL: https://github.com/apache/arrow-adbc/pull/681#discussion_r1196693342


##########
adbc.h:
##########
@@ -669,6 +675,16 @@ struct ADBC_EXPORT AdbcDriver {
                                               size_t, struct AdbcError*);
 };
 
+/// \brief An instance of an initialized database driver (API 1.1.0).
+///
+/// This provides a common interface for vendor-specific driver
+/// initialization routines. Drivers should populate this struct, and
+/// applications can call ADBC functions through this struct, without
+/// worrying about multiple definitions of the same symbol.
+struct ADBC_EXPORT AdbcDriver110 {
+  struct AdbcDriver base;
+};

Review Comment:
   You can't add items to a struct without breaking binary compatibility.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org