You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/01/27 07:18:10 UTC
[GitHub] [incubator-doris] zuochunwei opened a new pull request #7906: (storage) add debug-timer for the purpose of testing
zuochunwei opened a new pull request #7906:
URL: https://github.com/apache/incubator-doris/pull/7906
# Proposed changes
add a group of debug-timer for the purpose of testing
you can use these timers for custom meaning purpose unlike the specific named timer
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zuochunwei commented on pull request #7906: (storage) add debug-timer for the purpose of testing
Posted by GitBox <gi...@apache.org>.
zuochunwei commented on pull request #7906:
URL: https://github.com/apache/incubator-doris/pull/7906#issuecomment-1022973342
> We'd better not add `Timer` in hot code path, especially in Page.next_batch, because the Timer itself may cost lots of time.
i got, just for test
this version is not the final
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zuochunwei commented on pull request #7906: (storage) add debug-timer for the purpose of testing
Posted by GitBox <gi...@apache.org>.
zuochunwei commented on pull request #7906:
URL: https://github.com/apache/incubator-doris/pull/7906#issuecomment-1022979072
i just want to provide this method for testing any code cost,
so i marked as '//demo DEBUG timer ' to indicate that this codes will be deleted later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wangbo commented on pull request #7906: (storage) add debug-timer for the purpose of testing
Posted by GitBox <gi...@apache.org>.
wangbo commented on pull request #7906:
URL: https://github.com/apache/incubator-doris/pull/7906#issuecomment-1022919224
We'd better not add ```Timer``` in hot code path, especially in Page.next_batch, because the Timer itself may cost lots of time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zuochunwei closed pull request #7906: (storage) add debug-timer for the purpose of testing
Posted by GitBox <gi...@apache.org>.
zuochunwei closed pull request #7906:
URL: https://github.com/apache/incubator-doris/pull/7906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org