[GitHub] [griffin] XiaoyuBD commented on a diff in pull request #628: JDBC Connector SQL mode

["XiaoyuBD (via GitHub)" <gi...@apache.org>]

XiaoyuBD commented on code in PR #628:
URL: https://github.com/apache/griffin/pull/628#discussion_r1113132637


##########
griffin-doc/measure/measure-configuration-guide.md:
##########
@@ -547,13 +547,15 @@ List of supported data connectors:
 | Name       | Type     | Description                            | Default Values |
 |:-----------|:---------|:---------------------------------------|:-------------- |
 | database   | `String` | database name                          | default |
+| sql        | `String` | query sql                              | `Empty` |

Review Comment:
   Thanks for the comment.  If the config `sql` was provided, `database`, `tablename` and `where` can all be ignored, connector will extract the result of sql. I added that description to the MD and added the SQL mode config example.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@griffin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org