You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Aki Yoshida (JIRA)" <ji...@apache.org> on 2012/08/13 16:00:54 UTC

[jira] [Created] (CXF-4469) 2.6.x rt-ws-security bundle is requiring opensaml

Aki Yoshida created CXF-4469:
--------------------------------

             Summary: 2.6.x rt-ws-security bundle is requiring opensaml
                 Key: CXF-4469
                 URL: https://issues.apache.org/jira/browse/CXF-4469
             Project: CXF
          Issue Type: Bug
          Components: WS-* Components
    Affects Versions: 2.6.1
            Reporter: Aki Yoshida
            Assignee: Aki Yoshida
             Fix For: 2.6.2


The CXF's 2.6.x's rt-ws-security bundle is requiring opensaml, although opensaml is supposed to be optional.

The cxf all bundle declares opensaml* as optional and not requiring them.

The rt-ws-security's pom also needs this optional import declaration.



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CXF-4469) 2.6.x rt-ws-security bundle is requiring opensaml

Posted by "Colm O hEigeartaigh (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434157#comment-13434157 ] 

Colm O hEigeartaigh commented on CXF-4469:
------------------------------------------

Hi Aki,

Either solution is fine with me.

Colm.
                
> 2.6.x rt-ws-security bundle is requiring opensaml
> -------------------------------------------------
>
>                 Key: CXF-4469
>                 URL: https://issues.apache.org/jira/browse/CXF-4469
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.6.1
>            Reporter: Aki Yoshida
>            Assignee: Aki Yoshida
>             Fix For: 2.6.2
>
>
> The CXF's 2.6.x's rt-ws-security bundle is requiring opensaml, although opensaml is supposed to be optional.
> The cxf all bundle declares opensaml* as optional and not requiring them.
> The rt-ws-security's pom also needs this optional import declaration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CXF-4469) 2.6.x rt-ws-security bundle is requiring opensaml

Posted by "Aki Yoshida (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434145#comment-13434145 ] 

Aki Yoshida commented on CXF-4469:
----------------------------------

Hi Colm,
as discussed on #cxf, I simply moved the parseRolesInAssertion methods to an internal utility class and added a method that takes the assertion wrapper and returns the list of roles in this class.

alternatively, we could have added another method getAssertion(Object assertionWrapper) in the utility class to get the assertion first and then call the parseRolesInAssertion(Object assertion, ...). In that case, we could have kept the replacement for those protected methods by adding protected parseRolesInAssertion(Object assertion, ...) in WSS4JInInterceptor that calls this utility method.

thanks.
regards, aki

                
> 2.6.x rt-ws-security bundle is requiring opensaml
> -------------------------------------------------
>
>                 Key: CXF-4469
>                 URL: https://issues.apache.org/jira/browse/CXF-4469
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.6.1
>            Reporter: Aki Yoshida
>            Assignee: Aki Yoshida
>             Fix For: 2.6.2
>
>
> The CXF's 2.6.x's rt-ws-security bundle is requiring opensaml, although opensaml is supposed to be optional.
> The cxf all bundle declares opensaml* as optional and not requiring them.
> The rt-ws-security's pom also needs this optional import declaration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CXF-4469) 2.6.x rt-ws-security bundle is requiring opensaml

Posted by "Colm O hEigeartaigh (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433158#comment-13433158 ] 

Colm O hEigeartaigh commented on CXF-4469:
------------------------------------------

Hi Aki,

Opensaml is not supposed to be optional any more since we moved to use WSS4J 1.6.0.

Colm.
                
> 2.6.x rt-ws-security bundle is requiring opensaml
> -------------------------------------------------
>
>                 Key: CXF-4469
>                 URL: https://issues.apache.org/jira/browse/CXF-4469
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.6.1
>            Reporter: Aki Yoshida
>            Assignee: Aki Yoshida
>             Fix For: 2.6.2
>
>
> The CXF's 2.6.x's rt-ws-security bundle is requiring opensaml, although opensaml is supposed to be optional.
> The cxf all bundle declares opensaml* as optional and not requiring them.
> The rt-ws-security's pom also needs this optional import declaration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Comment Edited] (CXF-4469) 2.6.x rt-ws-security bundle is requiring opensaml

Posted by "Aki Yoshida (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433344#comment-13433344 ] 

Aki Yoshida edited comment on CXF-4469 at 8/14/12 6:18 AM:
-----------------------------------------------------------

Hi Colm,
Okay. Thanks.

I looked at manifest in the wss4j.1.6.6.jar bundle and I saw the org.opensaml* stuff with optional resolution. So, I thought opensaml is still optional. But I saw they are referenced in rt-ws-security's WSS4JInInterceptor, so they seem to be required.

But I am still wondering if opensaml is declared as optional in wss4j 1.6.6, some ws security functionality may be provided without opensaml?

Regards, Aki
                
      was (Author: ay):
    Hi Colm,
I might be missing something.

I looked at manifest in the wss4j.1.6.6.jar bundle, and I saw the org.opensaml* stuff with optional resolution. So, I thought opensaml is still optional.

Regards, Aki
                  
> 2.6.x rt-ws-security bundle is requiring opensaml
> -------------------------------------------------
>
>                 Key: CXF-4469
>                 URL: https://issues.apache.org/jira/browse/CXF-4469
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.6.1
>            Reporter: Aki Yoshida
>            Assignee: Aki Yoshida
>             Fix For: 2.6.2
>
>
> The CXF's 2.6.x's rt-ws-security bundle is requiring opensaml, although opensaml is supposed to be optional.
> The cxf all bundle declares opensaml* as optional and not requiring them.
> The rt-ws-security's pom also needs this optional import declaration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CXF-4469) 2.6.x rt-ws-security bundle is requiring opensaml

Posted by "Aki Yoshida (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433344#comment-13433344 ] 

Aki Yoshida commented on CXF-4469:
----------------------------------

Hi Colm,
I might be missing something.

I looked at manifest in the wss4j.1.6.6.jar bundle, and I saw the org.opensaml* stuff with optional resolution. So, I thought opensaml is still optional.

Regards, Aki
                
> 2.6.x rt-ws-security bundle is requiring opensaml
> -------------------------------------------------
>
>                 Key: CXF-4469
>                 URL: https://issues.apache.org/jira/browse/CXF-4469
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.6.1
>            Reporter: Aki Yoshida
>            Assignee: Aki Yoshida
>             Fix For: 2.6.2
>
>
> The CXF's 2.6.x's rt-ws-security bundle is requiring opensaml, although opensaml is supposed to be optional.
> The cxf all bundle declares opensaml* as optional and not requiring them.
> The rt-ws-security's pom also needs this optional import declaration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (CXF-4469) 2.6.x rt-ws-security bundle is requiring opensaml

Posted by "Aki Yoshida (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aki Yoshida resolved CXF-4469.
------------------------------

       Resolution: Fixed
    Fix Version/s: 2.7.0
    
> 2.6.x rt-ws-security bundle is requiring opensaml
> -------------------------------------------------
>
>                 Key: CXF-4469
>                 URL: https://issues.apache.org/jira/browse/CXF-4469
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.6.1
>            Reporter: Aki Yoshida
>            Assignee: Aki Yoshida
>             Fix For: 2.6.2, 2.7.0
>
>
> The CXF's 2.6.x's rt-ws-security bundle is requiring opensaml, although opensaml is supposed to be optional.
> The cxf all bundle declares opensaml* as optional and not requiring them.
> The rt-ws-security's pom also needs this optional import declaration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CXF-4469) 2.6.x rt-ws-security bundle is requiring opensaml

Posted by "Colm O hEigeartaigh (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CXF-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434020#comment-13434020 ] 

Colm O hEigeartaigh commented on CXF-4469:
------------------------------------------

Hi Aki,

Yes, all non-SAML WS-Security functionality in WSS4J is available without Opensaml. That is not the case though when you use WS-Security via the cxf-rt-ws-security module. We could possibly refactor the code such that a non-SAML use-case would work without having Opensaml available. What would be the point though?

Colm.
                
> 2.6.x rt-ws-security bundle is requiring opensaml
> -------------------------------------------------
>
>                 Key: CXF-4469
>                 URL: https://issues.apache.org/jira/browse/CXF-4469
>             Project: CXF
>          Issue Type: Bug
>          Components: WS-* Components
>    Affects Versions: 2.6.1
>            Reporter: Aki Yoshida
>            Assignee: Aki Yoshida
>             Fix For: 2.6.2
>
>
> The CXF's 2.6.x's rt-ws-security bundle is requiring opensaml, although opensaml is supposed to be optional.
> The cxf all bundle declares opensaml* as optional and not requiring them.
> The rt-ws-security's pom also needs this optional import declaration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira