[GitHub] [hudi] XuQianJin-Stars commented on a diff in pull request #5534: [HUDI-4056] Refine partition matching in when drop / truncate partition.

[GitBox <gi...@apache.org>]

XuQianJin-Stars commented on code in PR #5534:
URL: https://github.com/apache/hudi/pull/5534#discussion_r872949175


##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestAlterTableDropPartition.scala:
##########
@@ -81,13 +81,13 @@ class TestAlterTableDropPartition extends HoodieSparkSqlTestBase {
   }
 
   Seq(false, true).foreach { urlencode =>
-    test(s"Drop single-partition table' partitions, urlencode: $urlencode") {
+    test(s"Drop single-partition table's partitions, urlencode: $urlencode") {
       withTempDir { tmp =>
         val tableName = generateTableName
         val tablePath = s"${tmp.getCanonicalPath}/$tableName"
 
         import spark.implicits._
-        val df = Seq((1, "z3", "v1", "2021/10/01"), (2, "l4", "v1", "2021/10/02"))
+        val df = Seq((1, "z3", "v1", "2021#10#01"), (2, "l4", "v1", "2021#10#02"))

Review Comment:
    "#" While reducing errors, but increasing ut readability.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org