You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by dwhsys <gi...@git.apache.org> on 2017/01/20 14:50:15 UTC

[GitHub] zeppelin pull request #1917: [ZEPPELIN-1988] precode execution in JDBCInterp...

GitHub user dwhsys opened a pull request:

    https://github.com/apache/zeppelin/pull/1917

    [ZEPPELIN-1988] precode execution in JDBCInterpreter

    ### What is this PR for?
    PR adds new parameter in JDBC interpreter which allows to execute some SQL while opening connection. Parameter value could be parameterized by %noteId (value will be replaced by noteId from context).
    
    Parameter: default.precode
    Value examples:
    "select 1;" will be executed as "select 1;"
    "set application_name=%noteId;" will be executed as "set application_name='2C7MP5HD3';"
    
    If parameter is null then precode is ignored.
    
    
    ### What type of PR is it?
    Feature
    
    ### Todos
    * [ ] - ZEPPELIN-1988
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1988
    
    ### How should this be tested?
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? Yes


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dwhsys/zeppelin jdbc-precode

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1917.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1917
    
----
commit db2b0d96fd3f948f6e1043cd3bc0ecd4f7ab16ce
Author: v.poljakov <v....@tinkoff.ru>
Date:   2017-01-20T14:33:36Z

    jdbc-precode

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1917: [ZEPPELIN-1988] precode execution in JDBCInterp...

Posted by dwhsys <gi...@git.apache.org>.
Github user dwhsys closed the pull request at:

    https://github.com/apache/zeppelin/pull/1917


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1917: [ZEPPELIN-1988] precode execution in JDBCInterpreter

Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:

    https://github.com/apache/zeppelin/pull/1917
  
    Thank you for contribution!.
    please rebase PR and  
    If you let us know about testing way on detail, it's easy to review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---