You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/23 20:22:50 UTC

[GitHub] [spark] amaliujia commented on pull request #38768: [SPARK-41230][CONNECT][PYTHON] Remove `str` from Aggregate expression type

amaliujia commented on PR #38768:
URL: https://github.com/apache/spark/pull/38768#issuecomment-1325616449

   @zhengruifeng sure maybe we can do that refactoring in this PR directly.
   
   the plain `str` passing through to relations became a blocker for that refactoring (given there is no place for a plain `str` in expression system, it must be wrapped).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org