You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by kaspersorensen <gi...@git.apache.org> on 2016/04/21 18:46:37 UTC
[GitHub] metamodel pull request: METAMODEL-235: Fixed
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/94
METAMODEL-235: Fixed
This fixes METAMODEL-235 which was essentially about supporting null values and missing values in the REST API of ElasticSearch.
I also expanded the unittests a bit in general around the relevant utility class. It seemed that it didn't have a lot of corner cases covered so now I added a couple at least.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kaspersorensen/metamodel METAMODEL-235
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/94.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #94
----
commit 6a669d7fb2190c6349f386f38c2bb515b7b80bfe
Author: kaspersorensen <i....@gmail.com>
Date: 2016-04-21T16:44:37Z
METAMODEL-235: Fixed
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: METAMODEL-235: Fixed
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/94#issuecomment-213040943
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: METAMODEL-235: Fixed
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/94#discussion_r60628058
--- Diff: .gitignore ---
@@ -1,6 +1,6 @@
.project
-.settings/
--- End diff --
Probably not anything that breaks stuff, though :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: METAMODEL-235: Fixed
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/94#discussion_r60627530
--- Diff: .gitignore ---
@@ -1,6 +1,6 @@
.project
-.settings/
--- End diff --
Yes you're right. That should have only been a change for `.classpath`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: METAMODEL-235: Fixed
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/94
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: METAMODEL-235: Fixed
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/94#discussion_r60625713
--- Diff: .gitignore ---
@@ -1,6 +1,6 @@
.project
-.settings/
--- End diff --
Isn't .settings a folder?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---