You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org> on 2019/11/08 01:57:08 UTC

[Impala-ASF-CR] IMPALA-9092 : Disable show create table tests on Kudu

Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14664


Change subject: IMPALA-9092 : Disable show create table tests on Kudu
......................................................................

IMPALA-9092 : Disable show create table tests on Kudu

This patch temporarily disables the Kudu tests which fail when we try to bump up the CDP
build number due the HMS translation. The tests will be re-enabled back again when the fix
for IMPALA-9092 is submitted.

Testing Done:
1. Bumped up the CDP build number to 1507246 which has the HMS translation in it.
2. Ran core tests and found the tests which are failing for Kudu due to this issue.
3. Ran the failing tests again and confirm they are not failing anymore.

Change-Id: I37c0b6d82372bc6380285afcd94f0c1e123f2eda
---
M tests/common/skip.py
M tests/metadata/test_show_create_table.py
M tests/query_test/test_kudu.py
3 files changed, 11 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/14664/2
-- 
To view, visit http://gerrit.cloudera.org:8080/14664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I37c0b6d82372bc6380285afcd94f0c1e123f2eda
Gerrit-Change-Number: 14664
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-9092 : Disable show create table tests on Kudu

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.

Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14664 )

Change subject: IMPALA-9092 : Disable show create table tests on Kudu
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/14664/3/tests/metadata/test_ddl.py
File tests/metadata/test_ddl.py:

http://gerrit.cloudera.org:8080/#/c/14664/3/tests/metadata/test_ddl.py@684
PS3, Line 684: external.purge.table
This should be "external.table.purge"


http://gerrit.cloudera.org:8080/#/c/14664/3/tests/metadata/test_ddl.py@687
PS3, Line 687:       del properties['external.purge.table']
This should be "external.table.purge"



-- 
To view, visit http://gerrit.cloudera.org:8080/14664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37c0b6d82372bc6380285afcd94f0c1e123f2eda
Gerrit-Change-Number: 14664
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 Nov 2019 01:41:57 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9092 : Disable show create table tests on Kudu

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14664 )

Change subject: IMPALA-9092 : Disable show create table tests on Kudu
......................................................................


Patch Set 5: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5219/


-- 
To view, visit http://gerrit.cloudera.org:8080/14664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37c0b6d82372bc6380285afcd94f0c1e123f2eda
Gerrit-Change-Number: 14664
Gerrit-PatchSet: 5
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Sat, 16 Nov 2019 06:08:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9092 : Disable show create table tests on Kudu

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14664 )

Change subject: IMPALA-9092 : Disable show create table tests on Kudu
......................................................................


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5219/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/14664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37c0b6d82372bc6380285afcd94f0c1e123f2eda
Gerrit-Change-Number: 14664
Gerrit-PatchSet: 5
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Nov 2019 20:08:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9092 : Disable show create table tests on Kudu

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14664 )

Change subject: IMPALA-9092 : Disable show create table tests on Kudu
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5024/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/14664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37c0b6d82372bc6380285afcd94f0c1e123f2eda
Gerrit-Change-Number: 14664
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Nov 2019 00:28:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9092 : Disable show create table tests on Kudu

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.

Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14664 )

Change subject: IMPALA-9092 : Disable show create table tests on Kudu
......................................................................


Patch Set 3:

I think it makes sense to move forward with this, since the fix for IMPALA-9068 needs a newer CDP GBN. We don't want to block IMPALA-9068 to wait for IMPALA-9092.


-- 
To view, visit http://gerrit.cloudera.org:8080/14664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37c0b6d82372bc6380285afcd94f0c1e123f2eda
Gerrit-Change-Number: 14664
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Nov 2019 22:20:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9092 : Disable show create table tests on Kudu

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14664 )

Change subject: IMPALA-9092 : Disable show create table tests on Kudu
......................................................................


Patch Set 5: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/14664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37c0b6d82372bc6380285afcd94f0c1e123f2eda
Gerrit-Change-Number: 14664
Gerrit-PatchSet: 5
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Sat, 16 Nov 2019 21:44:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9092 : Disable show create table tests on Kudu

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14664 )

Change subject: IMPALA-9092 : Disable show create table tests on Kudu
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/4980/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/14664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37c0b6d82372bc6380285afcd94f0c1e123f2eda
Gerrit-Change-Number: 14664
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Nov 2019 02:41:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9092 : Disable show create table tests on Kudu

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.

Vihang Karajgaonkar has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/14664 )

Change subject: IMPALA-9092 : Disable show create table tests on Kudu
......................................................................

IMPALA-9092 : Disable show create table tests on Kudu

This patch temporarily disables the Kudu tests which fail when we try to bump up the CDP
build number due the HMS translation. The tests will be re-enabled back again when the fix
for IMPALA-9092 is submitted.

Testing Done:
1. Bumped up the CDP build number to 1507246 which has the HMS translation in it.
2. Ran core tests and found the tests which are failing for Kudu due to this issue.
3. Ran the failing tests again and confirm they are not failing anymore.

Change-Id: I37c0b6d82372bc6380285afcd94f0c1e123f2eda
---
M fe/src/test/java/org/apache/impala/catalog/CatalogTest.java
M fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java
M tests/common/skip.py
M tests/metadata/test_ddl.py
M tests/metadata/test_show_create_table.py
M tests/query_test/test_kudu.py
6 files changed, 25 insertions(+), 4 deletions(-)

git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/14664/4
--
To view, visit http://gerrit.cloudera.org:8080/14664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I37c0b6d82372bc6380285afcd94f0c1e123f2eda
Gerrit-Change-Number: 14664
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] IMPALA-9092 : Disable show create table tests on Kudu

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14664 )

Change subject: IMPALA-9092 : Disable show create table tests on Kudu
......................................................................


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5226/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/14664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37c0b6d82372bc6380285afcd94f0c1e123f2eda
Gerrit-Change-Number: 14664
Gerrit-PatchSet: 5
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Sat, 16 Nov 2019 17:09:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9092 : Disable show create table tests on Kudu

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14664 )

Change subject: IMPALA-9092 : Disable show create table tests on Kudu
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37c0b6d82372bc6380285afcd94f0c1e123f2eda
Gerrit-Change-Number: 14664
Gerrit-PatchSet: 5
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Nov 2019 20:08:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9092 : Disable show create table tests on Kudu

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.

Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14664 )

Change subject: IMPALA-9092 : Disable show create table tests on Kudu
......................................................................


Patch Set 4: Code-Review+2

Thanks for doing this! We'll need to fix and reenable these, but this will let IMPALA-9068 go ahead.


-- 
To view, visit http://gerrit.cloudera.org:8080/14664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37c0b6d82372bc6380285afcd94f0c1e123f2eda
Gerrit-Change-Number: 14664
Gerrit-PatchSet: 4
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Nov 2019 18:53:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9092 : Disable show create table tests on Kudu

Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.

Vihang Karajgaonkar has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/14664 )

Change subject: IMPALA-9092 : Disable show create table tests on Kudu
......................................................................

IMPALA-9092 : Disable show create table tests on Kudu

git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/14664/3
--
To view, visit http://gerrit.cloudera.org:8080/14664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I37c0b6d82372bc6380285afcd94f0c1e123f2eda
Gerrit-Change-Number: 14664
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] IMPALA-9092 : Disable show create table tests on Kudu

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.

Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14664 )

Change subject: IMPALA-9092 : Disable show create table tests on Kudu
......................................................................

IMPALA-9092 : Disable show create table tests on Kudu

Change-Id: I37c0b6d82372bc6380285afcd94f0c1e123f2eda
Reviewed-on: http://gerrit.cloudera.org:8080/14664
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/test/java/org/apache/impala/catalog/CatalogTest.java
M fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java
M tests/common/skip.py
M tests/metadata/test_ddl.py
M tests/metadata/test_show_create_table.py
M tests/query_test/test_kudu.py
6 files changed, 25 insertions(+), 4 deletions(-)

Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/14664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I37c0b6d82372bc6380285afcd94f0c1e123f2eda
Gerrit-Change-Number: 14664
Gerrit-PatchSet: 6
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] IMPALA-9092 : Disable show create table tests on Kudu

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.

Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14664 )

Change subject: IMPALA-9092 : Disable show create table tests on Kudu
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/4989/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/14664
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I37c0b6d82372bc6380285afcd94f0c1e123f2eda
Gerrit-Change-Number: 14664
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Comment-Date: Fri, 08 Nov 2019 21:26:16 +0000
Gerrit-HasComments: No