You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/06/25 05:32:18 UTC

[GitHub] [arrow] kou opened a new pull request, #36281: GH-36239: [CI][C++] Add support for multiple flags for ARROW_*_FLAGS_*

kou opened a new pull request, #36281:
URL: https://github.com/apache/arrow/pull/36281

   ### Rationale for this change
   
   Quoting is needed for multiple flags.
   
   ### What changes are included in this PR?
   
   Add quoting.
   
   ### Are these changes tested?
   
   Yes.
   
   ### Are there any user-facing changes?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou commented on pull request #36281: GH-36239: [CI][C++] Add support for multiple flags for ARROW_*_FLAGS_*

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #36281:
URL: https://github.com/apache/arrow/pull/36281#issuecomment-1606718401

   +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #36281: GH-36239: [CI][C++] Add support for multiple flags for ARROW_*_FLAGS_*

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #36281:
URL: https://github.com/apache/arrow/pull/36281#issuecomment-1611430820

   Conbench analyzed the 6 benchmark runs on commit `1e7f2fd4`.
   
   There were 2 benchmark results indicating a performance regression:
   
   - Commit Run on `ursa-i9-9960x` at [2023-06-28 10:51:11Z](http://conbench.ursa.dev/compare/runs/fd6da697fe514bf18f3b372bf0f90ab1...1521d8e35a434b27ba292ce10c7269c3/)
     - [engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-06, scale_factor=1](http://conbench.ursa.dev/compare/benchmarks/0649bfe2ad537b95800018166dcc4cd8...0649c2ad45b77b9b8000d4af349d556e)
     - [engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-06, scale_factor=1](http://conbench.ursa.dev/compare/benchmarks/0649bfe350837e838000939470218363...0649c2ae52aa76438000124daa9389b0)
   
   The [full Conbench report](https://github.com/apache/arrow/runs/14624753088) has more details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #36281: GH-36239: [CI][C++] Add support for multiple flags for ARROW_*_FLAGS_*

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36281:
URL: https://github.com/apache/arrow/pull/36281#issuecomment-1605879082

   :warning: GitHub issue #36239 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kou merged pull request #36281: GH-36239: [CI][C++] Add support for multiple flags for ARROW_*_FLAGS_*

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #36281:
URL: https://github.com/apache/arrow/pull/36281


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org