You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/08 14:40:55 UTC
[GitHub] [doris] luozenglin opened a new pull request, #13193: [feature](function) support `initcap` string function in vectorized engine.
luozenglin opened a new pull request, #13193:
URL: https://github.com/apache/doris/pull/13193
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [x] No
- [ ] No Need
3. Has document been added or modified:
- [x] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt merged pull request #13193: [feature](function) support `initcap` string function.
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt merged PR #13193:
URL: https://github.com/apache/doris/pull/13193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] luozenglin commented on a diff in pull request #13193: [feature](function) support `initcap` string function.
Posted by GitBox <gi...@apache.org>.
luozenglin commented on code in PR #13193:
URL: https://github.com/apache/doris/pull/13193#discussion_r990745229
##########
be/src/vec/functions/function_string.cpp:
##########
@@ -265,6 +265,45 @@ struct TransferImpl {
}
};
+// Capitalize first letter
+struct NameToInitcap {
+ static constexpr auto name = "initcap";
+};
+
+struct InitcapImpl {
+ static Status vector(const ColumnString::Chars& data, const ColumnString::Offsets& offsets,
+ ColumnString::Chars& res_data, ColumnString::Offsets& res_offsets) {
+ size_t offset_size = offsets.size();
+ res_offsets.resize(offsets.size());
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #13193: [feature](function) support `initcap` string function in vectorized engine.
Posted by GitBox <gi...@apache.org>.
HappenLee commented on code in PR #13193:
URL: https://github.com/apache/doris/pull/13193#discussion_r990724580
##########
be/src/vec/functions/function_string.cpp:
##########
@@ -265,6 +265,45 @@ struct TransferImpl {
}
};
+// Capitalize first letter
+struct NameToInitcap {
+ static constexpr auto name = "initcap";
+};
+
+struct InitcapImpl {
+ static Status vector(const ColumnString::Chars& data, const ColumnString::Offsets& offsets,
+ ColumnString::Chars& res_data, ColumnString::Offsets& res_offsets) {
+ size_t offset_size = offsets.size();
+ res_offsets.resize(offsets.size());
Review Comment:
here maybe need memcpy， the offset do not change
##########
be/src/exprs/string_functions.cpp:
##########
@@ -350,6 +350,29 @@ StringVal StringFunctions::upper(FunctionContext* context, const StringVal& str)
return result;
}
+StringVal StringFunctions::initcap(FunctionContext* context, const StringVal& str) {
+ if (str.is_null) {
+ return StringVal::null();
+ }
+ StringVal result(context, str.len);
+ if (UNLIKELY(result.is_null)) {
Review Comment:
seems not will be null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13193: [feature](function) support `initcap` string function.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13193:
URL: https://github.com/apache/doris/pull/13193#issuecomment-1272478649
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] luozenglin commented on a diff in pull request #13193: [feature](function) support `initcap` string function.
Posted by GitBox <gi...@apache.org>.
luozenglin commented on code in PR #13193:
URL: https://github.com/apache/doris/pull/13193#discussion_r990745209
##########
be/src/exprs/string_functions.cpp:
##########
@@ -350,6 +350,29 @@ StringVal StringFunctions::upper(FunctionContext* context, const StringVal& str)
return result;
}
+StringVal StringFunctions::initcap(FunctionContext* context, const StringVal& str) {
+ if (str.is_null) {
+ return StringVal::null();
+ }
+ StringVal result(context, str.len);
+ if (UNLIKELY(result.is_null)) {
Review Comment:
I have removed it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13193: [feature](function) support `initcap` string function.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13193:
URL: https://github.com/apache/doris/pull/13193#issuecomment-1272478642
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org