[GitHub] [doris] mrhhsg commented on a diff in pull request #11175: [improvement]Use phmap for aggregation with integer keys

[GitBox <gi...@apache.org>]

mrhhsg commented on code in PR #11175:
URL: https://github.com/apache/doris/pull/11175#discussion_r929017035


##########
be/src/vec/exec/vaggregation_node.cpp:
##########
@@ -208,20 +229,36 @@ void AggregationNode::_init_hash_method(std::vector<VExprContext*>& probe_exprs)
         if (use_fixed_key) {
             if (has_null) {
                 if (std::tuple_size<KeysNullMap<UInt64>>::value + key_byte_size <= sizeof(UInt64)) {
-                    _agg_data.init(AggregatedDataVariants::Type::int64_keys, has_null);
+                    if (_is_streaming_preagg)
+                        _agg_data.init(AggregatedDataVariants::Type::int64_keys, has_null);
+                    else
+                        _agg_data.init(AggregatedDataVariants::Type::int64_keys_phase2, has_null);

Review Comment:
   Yes, here replaced this with `_is_merge` to check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org