[GitHub] [ozone] duongkame commented on pull request #4219: HDDS-7851. Apply flush and compact on all column families

["duongkame (via GitHub)" <gi...@apache.org>]

duongkame commented on PR #4219:
URL: https://github.com/apache/ozone/pull/4219#issuecomment-1409170063

   > > Should the column family be flushed when flushing the wal as well?
   > 
   > @kerneltime Thank you for the review. Are your refering to the function of "db.flushWal(bool)"? I think the wal is shared by all column families, should be no need of this operation.
   
   I think WAL is flushed (to OS cache) automatically after each writes to achieve durability (unless Ozone has a config to disable it).
   
   On the other hand, this PR deals with flushing column families' memtables to SST files to persist the compaction after a snapshot is taken. We already flush memtable of the default column family so it makes sense to flush all the column families as well. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org